Re: OpenACC C front end maintenance: c_parser_oacc_single_int_clause (was: [OpenACC] num_gangs, num_workers and vector_length in c++)

2017-05-10 Thread Jakub Jelinek
On Tue, May 09, 2017 at 11:27:14PM +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 4 Nov 2015 14:10:29 -0800, Cesar Philippidis > wrote: > > > [...] > > > > Thanks. I've applied this patch to trunk. > > > gcc/cp/ > > * (cp_parser_oacc_single_int_clause): New function. > > (cp_parse

OpenACC C front end maintenance: c_parser_oacc_single_int_clause (was: [OpenACC] num_gangs, num_workers and vector_length in c++)

2017-05-09 Thread Thomas Schwinge
Hi! On Wed, 4 Nov 2015 14:10:29 -0800, Cesar Philippidis wrote: > > [...] > > Thanks. I've applied this patch to trunk. > gcc/cp/ > * (cp_parser_oacc_single_int_clause): New function. > (cp_parser_oacc_clause_vector_length): Delete. > (cp_parser_omp_clause_num_gangs): D

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-11-04 Thread Cesar Philippidis
On 11/04/2015 10:09 AM, Jason Merrill wrote: > A single function is better, to avoid unnecessary code duplication. Thanks. I've applied this patch to trunk. Cesar 2015-11-04 Cesar Philippidis gcc/cp/ * (cp_parser_oacc_single_int_clause): New function. (cp_parser_oacc_clause_vector_length

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-11-04 Thread Jason Merrill
On 10/30/2015 05:21 PM, Cesar Philippidis wrote: On 10/30/2015 10:05 AM, Jakub Jelinek wrote: On Fri, Oct 30, 2015 at 07:42:39AM -0700, Cesar Philippidis wrote: Another thing is what Jason as C++ maintainer wants, it is nice to get rid of some code redundancies, on the other side the fact tha

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 10:05 AM, Jakub Jelinek wrote: > On Fri, Oct 30, 2015 at 07:42:39AM -0700, Cesar Philippidis wrote: >>> Another thing is what Jason as C++ maintainer wants, it is nice to get rid >>> of some code redundancies, on the other side the fact that there is one >>> function per non-terminal

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Jakub Jelinek
On Fri, Oct 30, 2015 at 07:42:39AM -0700, Cesar Philippidis wrote: > The openacc spec doesn't actually define int-expr, but we take to me > mean a single integral value. In general, the openacc spec uses the term > list to describe comma separated expressions. So we've been assuming So does OpenMP

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 06:37 AM, Jakub Jelinek wrote: > On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: >> I noticed that num_gangs, num_workers and vector_length are parsed in >> somewhat insistent ways in the c++ FE. Both vector_length and num_gangs >> bail out whenever as soon as they

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Jakub Jelinek
On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: > I noticed that num_gangs, num_workers and vector_length are parsed in > somewhat insistent ways in the c++ FE. Both vector_length and num_gangs > bail out whenever as soon as they detect errors, whereas num_workers > does not. Bes

[OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-29 Thread Cesar Philippidis
I noticed that num_gangs, num_workers and vector_length are parsed in somewhat insistent ways in the c++ FE. Both vector_length and num_gangs bail out whenever as soon as they detect errors, whereas num_workers does not. Besides for that, they are also checking for integral expressions as the argum