Re: [OG12][PATCH] OpenMP: Fix ICE with OMP metadirectives

2022-09-28 Thread Tobias Burnus
Hi Paul-Antoine, hi all, On 28.09.22 15:47, Paul-Antoine Arras wrote: Here is a revised patch resulting from your comments. The only issue that I could not easily fix is the following code triggering an ICE: [...] I filed a PR on Bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107067 Is i

Re: [OG12][PATCH] OpenMP: Fix ICE with OMP metadirectives

2022-09-28 Thread Paul-Antoine Arras
Hi Tobias, Thanks for your review. Here is a revised patch resulting from your comments. The only issue that I could not easily fix is the following code triggering an ICE: ``` !$OMP begin metadirective & !$OMP when ( user = { condition ( UseDevice ) } & !$OMP : nothing ) &

Re: [OG12][PATCH] OpenMP: Fix ICE with OMP metadirectives

2022-09-22 Thread Tobias Burnus
Hello Paul-Antoine, hi all, On 21.09.22 23:18, Paul-Antoine Arras wrote: Here is a patch that fixes an ICE in gfortran triggered by an invalid end statement at the end of an OMP metadirective: Remark for other reads of this email: This only applies to OG12 as mainline does not have the follo

[OG12][PATCH] OpenMP: Fix ICE with OMP metadirectives

2022-09-21 Thread Paul-Antoine Arras
Hello, Here is a patch that fixes an ICE in gfortran triggered by an invalid end statement at the end of an OMP metadirective: ``` !$OMP metadirective ... ... !$OMP end ... ``` Does this fix look correct? Thanks, -- Paul-Antoine ArrasFrom 73ecbc2672a5352a08260f7a9d0de6d2c29ea