Re: [LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-03-04 Thread Christophe Lyon
On Mon, 4 Mar 2019 at 17:37, Jason Merrill wrote: > > On Mon, Mar 4, 2019 at 8:41 AM Christophe Lyon > wrote: > > On Wed, 20 Feb 2019 at 02:58, Jason Merrill wrote: > > > > > > A type in an anonymous namespace can never be merged with one from > > > another translation unit, so a member of such

Re: [LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-03-04 Thread Jason Merrill
On Mon, Mar 4, 2019 at 8:41 AM Christophe Lyon wrote: > On Wed, 20 Feb 2019 at 02:58, Jason Merrill wrote: > > > > A type in an anonymous namespace can never be merged with one from > > another translation unit, so a member of such a type is always its own > > prevailing decl. > > > > I don't rea

Re: [LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-03-04 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 02:58, Jason Merrill wrote: > > A type in an anonymous namespace can never be merged with one from > another translation unit, so a member of such a type is always its own > prevailing decl. > > I don't really understand the LTO concept of prevailing decl, or why we don't >

Re: [LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-02-20 Thread Jason Merrill
On Tue, Feb 19, 2019 at 10:53 PM Richard Biener wrote: > On Wed, Feb 20, 2019 at 2:58 AM Jason Merrill wrote: > > > > A type in an anonymous namespace can never be merged with one from > > another translation unit, so a member of such a type is always its own > > prevailing decl. > > > > I don't

Re: [LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-02-20 Thread Richard Biener
On Wed, Feb 20, 2019 at 2:58 AM Jason Merrill wrote: > > A type in an anonymous namespace can never be merged with one from > another translation unit, so a member of such a type is always its own > prevailing decl. > > I don't really understand the LTO concept of prevailing decl, or why we don't

[LTO PATCH RFA] PR c++/88049 - ICE with undefined destructor and anon namespace.

2019-02-19 Thread Jason Merrill
A type in an anonymous namespace can never be merged with one from another translation unit, so a member of such a type is always its own prevailing decl. I don't really understand the LTO concept of prevailing decl, or why we don't get here if the destructor is defined, but this seems reasonable