Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Dehao Chen
On Fri, May 10, 2013 at 11:32 AM, Teresa Johnson wrote: > On Fri, May 10, 2013 at 11:00 AM, Dehao Chen wrote: >> On Fri, May 10, 2013 at 10:47 AM, Teresa Johnson >> wrote: >>> Is it only auto fdo that doesn't store the module info if the module >>> is not exported or has aux modules? Note that

Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Dehao Chen
Right now, the error was prevented from the profile_creation tool side. In GCC, we only assume that the all exported modules will have primary module entry stored in profile. We can also check it when reading in profile, but that might be too costly because every compilation (even for those files t

Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Teresa Johnson
On Fri, May 10, 2013 at 11:00 AM, Dehao Chen wrote: > On Fri, May 10, 2013 at 10:47 AM, Teresa Johnson wrote: >> Is it only auto fdo that doesn't store the module info if the module >> is not exported or has aux modules? Note that this will prevent usage >> of my script that enables annotation of

Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Xinliang David Li
ok. Would be nicer if there is a way to tell this from other error cases though. David On Fri, May 10, 2013 at 11:00 AM, Dehao Chen wrote: > On Fri, May 10, 2013 at 10:47 AM, Teresa Johnson wrote: >> Is it only auto fdo that doesn't store the module info if the module >> is not exported or has

Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Dehao Chen
On Fri, May 10, 2013 at 10:47 AM, Teresa Johnson wrote: > Is it only auto fdo that doesn't store the module info if the module > is not exported or has aux modules? Note that this will prevent usage > of my script that enables annotation of gcov dump info with function > names, which relies on acc

Re: [Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Teresa Johnson
Is it only auto fdo that doesn't store the module info if the module is not exported or has aux modules? Note that this will prevent usage of my script that enables annotation of gcov dump info with function names, which relies on accessing the primary module info to obtain the module name (which i

[Google] Suppress message when primary module entry cannot found

2013-05-10 Thread Dehao Chen
Now we don't store the module info if the module is not exported or has any aux module (to compress the profile data size). Thus it's normal that a primary module entry cannot be found. This patch suppresses the messages printed when the primary module is not found. Bootstrapped and passed regress