Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
On Tue, May 20, 2014 at 8:39 AM, Xinliang David Li wrote: > On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson wrote: >> On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li >> wrote: >>> Why duplicating the merger functions in dyn-ipa.c? Should those in >>> libgcov-merge.c be reused? >> >> The mer

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Xinliang David Li
On Tue, May 20, 2014 at 6:32 AM, Teresa Johnson wrote: > On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li > wrote: >> Why duplicating the merger functions in dyn-ipa.c? Should those in >> libgcov-merge.c be reused? > > The merger functions in libgcov-merge.c use a macro to either read the > c

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-20 Thread Teresa Johnson
On Mon, May 19, 2014 at 11:51 PM, Xinliang David Li wrote: > Why duplicating the merger functions in dyn-ipa.c? Should those in > libgcov-merge.c be reused? The merger functions in libgcov-merge.c use a macro to either read the counter to merge from a buffer in memory (when IN_GCOV_TOOL) or from

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Xinliang David Li
Why duplicating the merger functions in dyn-ipa.c? Should those in libgcov-merge.c be reused? The refactoring of gcov_exit_write_gcda should probably be done in a separate patch -- preferably submitted to trunk too. David On Mon, May 19, 2014 at 10:08 PM, Teresa Johnson wrote: > Ping. > Teresa

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Teresa Johnson
Ping. Teresa On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson wrote: > This patch applies profile fixups to COMDATs on the dyn ipa callgraph > at the end of LIPO module grouping (either in the profile gen run or > in gcov-tool). This is to address issues with missing profiles in the > out-of-line