Re: [GOOGLE] recalculate dominance before update_ssa in AutoFDO pass

2014-10-15 Thread Xinliang David Li
ok. David On Wed, Oct 15, 2014 at 4:00 PM, Dehao Chen wrote: > It's destroyed by gimple_value_profile_transformations. > > Patch updated to move the update_ssa early. > > Index: gcc/auto-profile.c > === > --- gcc/auto-profile.c (rev

Re: [GOOGLE] recalculate dominance before update_ssa in AutoFDO pass

2014-10-15 Thread Dehao Chen
It's destroyed by gimple_value_profile_transformations. Patch updated to move the update_ssa early. Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 216278) +++ gcc/auto-profile.c (working copy) @@ -1674,7 +1674,14 @@ a

Re: [GOOGLE] recalculate dominance before update_ssa in AutoFDO pass

2014-10-15 Thread Xinliang David Li
Is it destroyed by value profile transformations? Can you move the dominance recomputing code closer to where it gets invalidated? David On Wed, Oct 15, 2014 at 10:37 AM, Dehao Chen wrote: > This patch recalculates dominance info before update_ssa call in > AutoFDO. This fixes bug when dominance

[GOOGLE] recalculate dominance before update_ssa in AutoFDO pass

2014-10-15 Thread Dehao Chen
This patch recalculates dominance info before update_ssa call in AutoFDO. This fixes bug when dominance info is out-of-date and causes segfaults during update_ssa. Bootstrapped and regression test on-going. OK for google-4_9 branch? Thanks, Dehao Index: gcc/auto-profile.c ==