Re: [GOOGLE] Update AutoFDO annotation

2013-08-27 Thread Xinliang David Li
Ok. David On Tue, Aug 27, 2013 at 7:36 AM, Dehao Chen wrote: > Patch updated. > > Thanks, > Dehao > > On Mon, Aug 26, 2013 at 4:11 PM, Xinliang David Li wrote: >> Can you add missing documentation on functions like ...:get_count_info >> -- documenting return value etc. Also it might be better

Re: [GOOGLE] Update AutoFDO annotation

2013-08-27 Thread Dehao Chen
Patch updated. Thanks, Dehao On Mon, Aug 26, 2013 at 4:11 PM, Xinliang David Li wrote: > Can you add missing documentation on functions like ...:get_count_info > -- documenting return value etc. Also it might be better to avoid > using 'set' as the local variable name. Change it to something mo

Re: [GOOGLE] Update AutoFDO annotation

2013-08-26 Thread Xinliang David Li
Can you add missing documentation on functions like ...:get_count_info -- documenting return value etc. Also it might be better to avoid using 'set' as the local variable name. Change it to something more specific. thanks, David On Thu, Aug 22, 2013 at 3:56 PM, Dehao Chen wrote: > This patch h

[GOOGLE] Update AutoFDO annotation

2013-08-22 Thread Dehao Chen
This patch has 2 changes: 1. Now that we have discriminator for inlined callsite, we don't need special handling for callsite location any more. 2. If a source line is mapped to multiple BBs, only the first BB will be annotated. 3. Before actual annotation, mark everythin BB/edge as not annotated.