Re: [GOOGLE] Refactor the LIPO fixup

2014-03-27 Thread Xinliang David Li
ok. On Thu, Mar 27, 2014 at 9:02 AM, Dehao Chen wrote: > On Wed, Mar 26, 2014 at 4:05 PM, Xinliang David Li wrote: >> is cgraph_init_gid_map called after linking? > > Oh, forgot that part. It's interesting that the test can pass without > another cgraph_init_gid_map call. > > Patch updated. Rete

Re: [GOOGLE] Refactor the LIPO fixup

2014-03-27 Thread Dehao Chen
On Wed, Mar 26, 2014 at 4:05 PM, Xinliang David Li wrote: > is cgraph_init_gid_map called after linking? Oh, forgot that part. It's interesting that the test can pass without another cgraph_init_gid_map call. Patch updated. Retested and the performance is OK. Dehao > > David > > On Wed, Mar 26

Re: [GOOGLE] Refactor the LIPO fixup

2014-03-26 Thread Xinliang David Li
is cgraph_init_gid_map called after linking? David On Wed, Mar 26, 2014 at 3:54 PM, Dehao Chen wrote: > Patch updated, passed performance tests. > > Dehao > > On Tue, Mar 25, 2014 at 4:03 PM, Xinliang David Li wrote: >> Add comment to the new function. init_node_map is better invoked after >> t

Re: [GOOGLE] Refactor the LIPO fixup

2014-03-26 Thread Dehao Chen
Patch updated, passed performance tests. Dehao On Tue, Mar 25, 2014 at 4:03 PM, Xinliang David Li wrote: > Add comment to the new function. init_node_map is better invoked after > the link step to avoid creating entries with for dead nodes. > > Ok if large perf testing is fine. > > David > > On

Re: [GOOGLE] Refactor the LIPO fixup

2014-03-25 Thread Xinliang David Li
Add comment to the new function. init_node_map is better invoked after the link step to avoid creating entries with for dead nodes. Ok if large perf testing is fine. David On Tue, Mar 25, 2014 at 3:38 PM, Dehao Chen wrote: > This patch refactors LIPO fixup related code to move it into a > stand

[GOOGLE] Refactor the LIPO fixup

2014-03-25 Thread Dehao Chen
This patch refactors LIPO fixup related code to move it into a standalone function. This makes sure that symtab_remove_unreachable_nodes is called right after the fixup so that there is not dangling cgraph nodes any time. Bootstrapped and regression test on-going. OK for google-4_8? Thanks, Deha