Yes -- in current form, it is still needed. As you explained, the
linking & stmt fixup will need to be done after profile annotation as
autofdo uses assembler name for icall target matching.
David
On Fri, Sep 20, 2013 at 3:29 PM, Dehao Chen wrote:
> Now that both statement fixup and cfg cleanup
Now that both statement fixup and cfg cleanup are moved after
annotation. So setting of cgraph node's count is still needed, right?
Thanks,
Dehao
On Thu, Sep 19, 2013 at 9:28 PM, Xinliang David Li wrote:
> I did not catch this in the last review. The cleanup CFG should be
> done before afdo_anno
I did not catch this in the last review. The cleanup CFG should be
done before afdo_annotate_cfg and just after call statement fixup.
Otherwise the cfg cleanup will zero out all profile counts. After
moving this up, you don't need the follow up patch which sets the
cgraph node's count -- that shoul
ok.
David
On Thu, Sep 19, 2013 at 10:10 AM, Dehao Chen wrote:
> Thanks, patch updated:
>
> Index: gcc/Makefile.in
> ===
> --- gcc/Makefile.in (revision 202725)
> +++ gcc/Makefile.in (working copy)
> @@ -2960,7 +2960,7 @@ coverage.o
Thanks, patch updated:
Index: gcc/Makefile.in
===
--- gcc/Makefile.in (revision 202725)
+++ gcc/Makefile.in (working copy)
@@ -2960,7 +2960,7 @@ coverage.o : coverage.c $(GCOV_IO_H) $(CONFIG_H) $
auto-profile.o : auto-profile.c $(CON
On Wed, Sep 18, 2013 at 4:51 PM, Dehao Chen wrote:
> This patch fixup the call graph edge targets during AutoFDO pass, so
> that when rebuilding call graph edges, it can find the correct callee.
>
> Bootstrapped and passed regression test. Benchmark tests on-going.
>
> Ok for google-4_8 branch?
>
This patch fixup the call graph edge targets during AutoFDO pass, so
that when rebuilding call graph edges, it can find the correct callee.
Bootstrapped and passed regression test. Benchmark tests on-going.
Ok for google-4_8 branch?
Thanks,
Dehao
Index: gcc/Makefile.in
=
