Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-21 Thread Richard Biener
On Mon, Oct 20, 2014 at 5:53 PM, Xinliang David Li wrote: > On Mon, Oct 20, 2014 at 1:32 AM, Richard Biener > wrote: >> On Mon, Oct 20, 2014 at 12:02 AM, Xinliang David Li >> wrote: >>> On Sat, Oct 18, 2014 at 4:19 PM, Xinliang David Li >>> wrote: On Sat, Oct 18, 2014 at 3:27 PM, Jan Hub

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-20 Thread Xinliang David Li
On Mon, Oct 20, 2014 at 1:32 AM, Richard Biener wrote: > On Mon, Oct 20, 2014 at 12:02 AM, Xinliang David Li > wrote: >> On Sat, Oct 18, 2014 at 4:19 PM, Xinliang David Li >> wrote: >>> On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: > The difference in instrumentation runtime is huge

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-20 Thread Richard Biener
On Mon, Oct 20, 2014 at 12:02 AM, Xinliang David Li wrote: > On Sat, Oct 18, 2014 at 4:19 PM, Xinliang David Li wrote: >> On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: The difference in instrumentation runtime is huge -- as topn profiler is pretty expensive to run. With

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-19 Thread Xinliang David Li
On Sat, Oct 18, 2014 at 4:19 PM, Xinliang David Li wrote: > On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: >>> The difference in instrumentation runtime is huge -- as topn profiler >>> is pretty expensive to run. >>> >>> With FDO, it is probably better to make early inlining more aggressive

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Teresa Johnson
On Sat, Oct 18, 2014 at 4:26 PM, Jan Hubicka wrote: >> On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: >> >> The difference in instrumentation runtime is huge -- as topn profiler >> >> is pretty expensive to run. >> >> >> >> With FDO, it is probably better to make early inlining more aggressi

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Xinliang David Li
On Sat, Oct 18, 2014 at 4:26 PM, Jan Hubicka wrote: >> On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: >> >> The difference in instrumentation runtime is huge -- as topn profiler >> >> is pretty expensive to run. >> >> >> >> With FDO, it is probably better to make early inlining more aggressi

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Jan Hubicka
> On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: > >> The difference in instrumentation runtime is huge -- as topn profiler > >> is pretty expensive to run. > >> > >> With FDO, it is probably better to make early inlining more aggressive > >> in order to get more context sensitive profiling.

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Xinliang David Li
On Sat, Oct 18, 2014 at 3:27 PM, Jan Hubicka wrote: >> The difference in instrumentation runtime is huge -- as topn profiler >> is pretty expensive to run. >> >> With FDO, it is probably better to make early inlining more aggressive >> in order to get more context sensitive profiling. > > I agree

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Jan Hubicka
> The difference in instrumentation runtime is huge -- as topn profiler > is pretty expensive to run. > > With FDO, it is probably better to make early inlining more aggressive > in order to get more context sensitive profiling. I agree with that, I just would like to understand where increasing

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Xinliang David Li
ok. David On Sat, Oct 18, 2014 at 9:26 AM, Teresa Johnson wrote: > Increasing the number of early inliner iterations from 1 to 2 enables more > indirect calls to be promoted/inlined before instrumentation. This in turn > reduces the instrumentation overhead, particularly for more expensive indir

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Xinliang David Li
The difference in instrumentation runtime is huge -- as topn profiler is pretty expensive to run. With FDO, it is probably better to make early inlining more aggressive in order to get more context sensitive profiling. David On Sat, Oct 18, 2014 at 10:05 AM, Jan Hubicka wrote: >> Increasing the

Re: [GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Jan Hubicka
> Increasing the number of early inliner iterations from 1 to 2 enables more > indirect calls to be promoted/inlined before instrumentation. This in turn > reduces the instrumentation overhead, particularly for more expensive indirect > call topn profiling. How much difference you get here? One po

[GOOGLE] Increase max-early-inliner-iterations to 2 for profile-gen and use

2014-10-18 Thread Teresa Johnson
Increasing the number of early inliner iterations from 1 to 2 enables more indirect calls to be promoted/inlined before instrumentation. This in turn reduces the instrumentation overhead, particularly for more expensive indirect call topn profiling. Passes internal testing and regression tests. Ok