Re: [GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Xinliang David Li
Ok for google branch. David On Sat, Aug 23, 2014 at 11:58 AM, Teresa Johnson wrote: > The ICE is, because we create a new node when querying the node during > symtab_remove_unreachable_nodes after LIPO linking is complete, and > then try to access its resolved node, for which there is none. Trun

Re: [GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Teresa Johnson
The ICE is, because we create a new node when querying the node during symtab_remove_unreachable_nodes after LIPO linking is complete, and then try to access its resolved node, for which there is none. Trunk has the same code in these two locations, but the creation of a new node after deleting the

Re: [GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Xinliang David Li
Is it a problem specific to LIPO? David On Sat, Aug 23, 2014 at 11:41 AM, Teresa Johnson wrote: > This patch ensures we don't prematurely delete an abstract origin node, > leading > to creating a new one after LIPO linking when we invoke similar handling in > symtab_remove_unreachable_nodes, wh

[GOOGLE] Fix AutoFDO LIPO ICE due to eliminated abstract origin

2014-08-23 Thread Teresa Johnson
This patch ensures we don't prematurely delete an abstract origin node, leading to creating a new one after LIPO linking when we invoke similar handling in symtab_remove_unreachable_nodes, which then does not have a resolved node. It makes the handling of such nodes equivalent to that in symtab_rem