The situation you described is worse -- hopefully it will be addressed
in the next version of lipo.
The change is ok.
David
On Tue, Oct 29, 2013 at 10:08 AM, Dehao Chen wrote:
> On Mon, Oct 28, 2013 at 9:49 PM, Xinliang David Li wrote:
>> Is it sufficient to check if the final caller is define
On Mon, Oct 28, 2013 at 9:49 PM, Xinliang David Li wrote:
> Is it sufficient to check if the final caller is defined in primary module?
This might not be sufficient because the final caller may come from
comdat of aux-modules (not defined in the primary module).
>
> Note that in some cases, doin
Is it sufficient to check if the final caller is defined in primary module?
Note that in some cases, doing profile update 'speculatively' (without
your fix) can be more precise (assuming the inlining gets materialized
in a different compilation), but in general it might be better to be
conservativ
This patch changes to no update callee count if caller count is not a
resolved node (in LIPO mode) during AutoFDO compilation. This is
because AutoFDO will have the same edge counts for all unresolved
nodes. Original update method will lead to multi-update of the callee.
Bootstrapped and testing o
