Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Vladimir Makarov
On 1/28/20 4:30 AM, Joel Hutton wrote: On 28/01/2020 09:07, Eric Botcazou wrote: Ping! Eric, do you have any objections to reverting? See my comment posted in the audit trail of the TN on 01/20... Probably missing live range splitting or somesuch, as envisioned by Vladimir in its approval messa

Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Joel Hutton
On 28/01/2020 09:07, Eric Botcazou wrote: >> Ping! Eric, do you have any objections to reverting? > > See my comment posted in the audit trail of the TN on 01/20... > Probably missing live range splitting or somesuch, as envisioned by > Vladimir in its approval message. Feel free to eventually re

Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Eric Botcazou
> Ping! Eric, do you have any objections to reverting? See my comment posted in the audit trail of the TN on 01/20... -- Eric Botcazou

[Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-27 Thread Joel Hutton
Ping! Eric, do you have any objections to reverting? On 21/01/2020 19:16, Vladimir Makarov wrote: > I am in favour of reverting the patch now.  But may be Eric can provide > another version of the patch not causing the arm problem.  I am ready to > reconsider this too.  So I guess the decision is

Re: [GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Joel Hutton
Changelog was mangled by thunderbird, updated changelog: Changelog: 2020-01-21 Joel Hutton PR target/93221 * ira.c (ira): Revert use of simplified LRA algorithm. gcc/testsuite/ChangeLog: 2020-01-21 Joel Hutton PR target/93221 * gcc.target/aarch64/

Re: [GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Joel Hutton
Updated changelog: Changelog: 2020-01-21 Joel Hutton PR target/93221 * ira.c (ira): Revert use of simplified LRA algorithm. gcc/testsuite/ChangeLog: 2020-01-21 Joel Hutton PR target/93221 * gcc.targe

Re: [GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Joel Hutton
On 21/01/2020 19:26, Jakub Jelinek wrote: > Not a review, just nitpicking. Please avoid the backslash before >. > The PR number should go to both gcc/ and gcc/testsuite/ ChangeLog > entry and we don't have bug/ category; the bug is target category, > so it should be PR target/93221, or could be re

Re: [GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2020 at 05:20:51PM +, Joel Hutton wrote: > 2020-01-21  Joel Hutton  > >     * ira.c (ira): Revert use of simplified LRA algorithm. > > gcc/testsuite/ChangeLog: > > 2020-01-21  Joel Hutton  > >     PR bug/93221 >     * gcc.target/aarch64/pr93221.c: New test.

Re: [GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Vladimir Makarov
On 1/21/20 12:20 PM, Joel Hutton wrote: Hi all, A previous change to simplify LRA introduced in 11b809 (From-SVN: r279550) disabled hard register splitting for -O0. This causes a problem on aarch64 in cases where parameters are passed in multiple registers (in the bug report an OI passed in 2 V4

[GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-21 Thread Joel Hutton
Hi all, A previous change to simplify LRA introduced in 11b809 (From-SVN: r279550) disabled hard register splitting for -O0. This causes a problem on aarch64 in cases where parameters are passed in multiple registers (in the bug report an OI passed in 2 V4SI registers). This is mandated by the