Re: [COMMITTED] Replace finite_operands_p with maybe_isnan.

2022-10-20 Thread Aldy Hernandez via Gcc-patches
On Thu, Oct 20, 2022 at 8:59 PM Mikael Morin wrote: > > Le 20/10/2022 à 20:56, Mikael Morin a écrit : > > > > Doesn't this miss a check of flag_finite_math_only to be strictly > > equivalent? You keep that check for the two-arguments case, so I guess > > it's not redundant? > > Well, the check is

Re: [COMMITTED] Replace finite_operands_p with maybe_isnan.

2022-10-20 Thread Mikael Morin
Le 20/10/2022 à 20:56, Mikael Morin a écrit : Doesn't this miss a check of flag_finite_math_only to be strictly equivalent?  You keep that check for the two-arguments case, so I guess it's not redundant? Well, the check is removed in the follow-up patch, so maybe is is after all.

Re: [COMMITTED] Replace finite_operands_p with maybe_isnan.

2022-10-20 Thread Mikael Morin
Hello, Le 20/10/2022 à 16:13, Aldy Hernandez via Gcc-patches a écrit : The finite_operands_p function was incorrectly named, as it only returned TRUE when !NAN. This was leftover from the initial implementation of frange. Using the maybe_isnan() nomenclature is more consistent and easier to un

[COMMITTED] Replace finite_operands_p with maybe_isnan.

2022-10-20 Thread Aldy Hernandez via Gcc-patches
The finite_operands_p function was incorrectly named, as it only returned TRUE when !NAN. This was leftover from the initial implementation of frange. Using the maybe_isnan() nomenclature is more consistent and easier to understand. gcc/ChangeLog: * range-op-float.cc (finite_operand_p):