Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Aldy Hernandez via Gcc-patches
On Tue, Nov 9, 2021 at 4:29 PM Andrew MacLeod wrote: > > On 11/9/21 9:39 AM, Martin Liška wrote: > > On 11/9/21 15:36, Aldy Hernandez wrote: > >> I don't see any ordering in these items, so I've placed it next to > >> another of the backward threader knobs. > >> > >> How does this look? > > > > Th

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Andrew MacLeod via Gcc-patches
On 11/9/21 9:39 AM, Martin Liška wrote: On 11/9/21 15:36, Aldy Hernandez wrote: I don't see any ordering in these items, so I've placed it next to another of the backward threader knobs. How does this look? That's fine, thanks. Note that similar --param 'ranger-debug' is also documented ;P

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Martin Liška
On 11/9/21 15:36, Aldy Hernandez wrote: I don't see any ordering in these items, so I've placed it next to another of the backward threader knobs. How does this look? That's fine, thanks. Note that similar --param 'ranger-debug' is also documented ;P Cheers, Martin

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Aldy Hernandez via Gcc-patches
On Tue, Nov 9, 2021 at 3:28 PM Martin Liška wrote: > > On 11/9/21 15:22, Aldy Hernandez wrote: > > On Tue, Nov 9, 2021 at 3:10 PM Martin Liška wrote: > >> > >>> +-param=threader-debug= > >> > >> Please document the param in gcc/doc/invoke.texi. > > > > I purposely didn't document it. This is an

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Martin Liška
On 11/9/21 15:22, Aldy Hernandez wrote: On Tue, Nov 9, 2021 at 3:10 PM Martin Liška wrote: +-param=threader-debug= Please document the param in gcc/doc/invoke.texi. I purposely didn't document it. This is an internal debugging construct. What's our policy on this? Well, quite some par

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Aldy Hernandez via Gcc-patches
On Tue, Nov 9, 2021 at 3:10 PM Martin Liška wrote: > > > +-param=threader-debug= > > Please document the param in gcc/doc/invoke.texi. I purposely didn't document it. This is an internal debugging construct. What's our policy on this? I'm happy to do this; I just didn't want the CI bots trying

Re: [COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Martin Liška
+-param=threader-debug= Please document the param in gcc/doc/invoke.texi. Missing: @item threader-debug threader-debug=[none|all] Enables verbose dumping of the threader solver. Cheers, Martin

[COMMITTED] Remove TDF_THREADING flag in favor of param.

2021-11-09 Thread Aldy Hernandez via Gcc-patches
I am returning a TDF_* flag to the queue of available entries as I am unconvinced that we need to burn an entire flag for internal debugging constructs, especially since we seem to be running out of them. I've added a --param=threader-debug entry similar to the one we use for ranger debugging. Cu