Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Iain Sandoe
On 29 Jan 2015, at 16:22, Richard Henderson wrote: >> >> Well, somewhat confusingly "x86/darwin_c.c" is shared between darwin and the >> various Windows 32 bit implementations. > > It's not shared with anything. It's a copy of the old x86/ffi.c > prior to the merge from upstream. yeah, I get

Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Richard Henderson
On 01/29/2015 01:10 AM, Iain Sandoe wrote: > > On 28 Jan 2015, at 18:16, Richard Henderson wrote: > >> On 01/28/2015 10:10 AM, Dominique d'Humières wrote: I can't think of any reason they shouldn't work. Were they not running before, or did something else change? >>> >>> AFAIU th

Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Dominique d'Humières
I have filed pr64855. Dominique > Le 29 janv. 2015 à 10:10, Iain Sandoe a écrit : > > > On 28 Jan 2015, at 18:16, Richard Henderson wrote: > >> On 01/28/2015 10:10 AM, Dominique d'Humières wrote: I can't think of any reason they shouldn't work. Were they not running before, o

Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Iain Sandoe
On 28 Jan 2015, at 18:16, Richard Henderson wrote: > On 01/28/2015 10:10 AM, Dominique d'Humières wrote: >>> I can't think of any reason they shouldn't work. Were they not running >>> before, >>> or did something else change? >> >> AFAIU the commit, the tests were not run on x86_64-*-*, so the

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Richard Henderson
On 01/28/2015 10:10 AM, Dominique d'Humières wrote: >> I can't think of any reason they shouldn't work. Were they not running >> before, >> or did something else change? > > AFAIU the commit, the tests were not run on x86_64-*-*, so the tests and the > corresponding failures are new. Well, the

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Dominique d'Humières
> Le 28 janv. 2015 à 19:03, Richard Henderson a écrit : > > On 01/28/2015 06:28 AM, Dominique Dhumieres wrote: >>> This patch worked for me. Ok for mainline now? (r220158) >> >> This causes 340 new tests on darwin with -m32, 255 of them failing when >> executes, >> see https://gcc.gnu.org/ml/

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Richard Henderson
On 01/28/2015 06:28 AM, Dominique Dhumieres wrote: >> This patch worked for me. Ok for mainline now? (r220158) > > This causes 340 new tests on darwin with -m32, 255 of them failing when > executes, > see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg03197.html. > > Are the tests with '-DAB

Re: [COMMITTED] Merge libffi with upstream

2015-01-28 Thread Dominique Dhumieres
> This patch worked for me. Ok for mainline now? (r220158) This causes 340 new tests on darwin with -m32, 255 of them failing when executes, see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg03197.html. Are the tests with '-DABI_NUM=*' supposed to work on darwin? If yes, I'll open a PR; if

Re: [COMMITTED] Merge libffi with upstream

2015-01-26 Thread Richard Henderson
On 01/26/2015 06:19 AM, Rainer Orth wrote: > 2015-01-16 Rainer Orth > > * testsuite/lib/libffi.exp: Load target-supports.exp. > (run-many-tests): Only set targetabis for ia32. Ok. r~

Re: [COMMITTED] Merge libffi with upstream

2015-01-26 Thread Rainer Orth
"H.J. Lu" writes: > On Fri, Jan 16, 2015 at 5:38 AM, Rainer Orth > wrote: >> Jakub Jelinek writes: >> @@ -311,7 +312,8 @@ proc run-many-tests { testcases extra_fl set targetabis { "" } if [string match $compiler_vendor "gnu"] { -if [istarget "i?86-*-*"

Re: [COMMITTED] Merge libffi with upstream

2015-01-24 Thread Gerald Pfeifer
Bootstrap on FreeBSD 10.x/i386 is now broken: libtool: compile: /scratch2/tmp/gerald/OBJ-0124-0939/./gcc/xgcc -B/scratch2/tmp/gerald/OBJ-0124-0939/./gcc/ -B/home/gerald/gcc-ref10-i386/i386-unknown-freebsd10.1/bin/ -B/home/gerald/gcc-ref10-i386/i386-unknown-freebsd10.1/lib/ -isystem /home/gera

Re: [COMMITTED] Merge libffi with upstream

2015-01-16 Thread Richard Henderson
On 01/15/2015 08:40 AM, Rainer Orth wrote: > * on Solaris/SPARC, /bin/as requires > > .type fn,#function Gas accepts this as well, so let's just use that. > * Yet unfixed for Solaris/SPARC /bin/as: > > as: "v8.s", line 128: error: invalid digit in radix 10 > > as seems to only understand s

Re: [COMMITTED] Merge libffi with upstream

2015-01-16 Thread H.J. Lu
On Fri, Jan 16, 2015 at 5:38 AM, Rainer Orth wrote: > Jakub Jelinek writes: > >>> @@ -311,7 +312,8 @@ proc run-many-tests { testcases extra_fl >>> >>> set targetabis { "" } >>> if [string match $compiler_vendor "gnu"] { >>> -if [istarget "i?86-*-*"] { >>> +if { ([istarge

Re: [COMMITTED] Merge libffi with upstream

2015-01-16 Thread Rainer Orth
Jakub Jelinek writes: >> @@ -311,7 +312,8 @@ proc run-many-tests { testcases extra_fl >> >> set targetabis { "" } >> if [string match $compiler_vendor "gnu"] { >> -if [istarget "i?86-*-*"] { >> +if { ([istarget "i?86-*-*"] || [istarget "x86_64-*-*"]) >> + && [i

Re: [COMMITTED] Merge libffi with upstream

2015-01-16 Thread Jakub Jelinek
On Fri, Jan 16, 2015 at 02:31:25PM +0100, Rainer Orth wrote: > * testsuite/lib/libffi.exp: Load target-supports.exp. > (run-many-tests): Only set targetabis for 32-bit x86. > > diff --git a/libffi/testsuite/lib/libffi.exp b/libffi/testsuite/lib/libffi.exp > --- a/libffi/testsuite/lib/

Re: [COMMITTED] Merge libffi with upstream

2015-01-16 Thread Rainer Orth
Rainer Orth writes: > Richard Henderson writes: > >> Upstream libffi has added support for Go closures (using the static chain), >> and support for complex numbers. Perhaps less relevant is new support for >> arc, microblaze, moxie, nios, and or1k targets. >> >> Without additional changes for G

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread H.J. Lu
On Thu, Jan 15, 2015 at 3:00 PM, Richard Henderson wrote: > On 01/15/2015 02:47 PM, H.J. Lu wrote: >> On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth >> wrote: >>> Richard Henderson writes: >>> Upstream libffi has added support for Go closures (using the static chain), and support for com

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread Richard Henderson
On 01/15/2015 02:47 PM, H.J. Lu wrote: > On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth > wrote: >> Richard Henderson writes: >> >>> Upstream libffi has added support for Go closures (using the static chain), >>> and support for complex numbers. Perhaps less relevant is new support for >>> arc, mi

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread H.J. Lu
On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth wrote: > Richard Henderson writes: > >> Upstream libffi has added support for Go closures (using the static chain), >> and support for complex numbers. Perhaps less relevant is new support for >> arc, microblaze, moxie, nios, and or1k targets. >> >> W

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread H.J. Lu
On Thu, Jan 15, 2015 at 9:19 AM, Richard Henderson wrote: > On 01/15/2015 08:54 AM, H.J. Lu wrote: >> On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth >> wrote: >>> Richard Henderson writes: >>> Upstream libffi has added support for Go closures (using the static chain), and support for com

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread Richard Henderson
On 01/15/2015 08:54 AM, H.J. Lu wrote: > On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth > wrote: >> Richard Henderson writes: >> >>> Upstream libffi has added support for Go closures (using the static chain), >>> and support for complex numbers. Perhaps less relevant is new support for >>> arc, mi

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread Richard Henderson
On 01/15/2015 08:40 AM, Rainer Orth wrote: > The patch introduced massive problems on Solaris, both SPARC and x86: > > * on Solaris/SPARC, /bin/as requires > > .type fn,#function > > instead of @function. I've simply commented the affected lines in > src/sparc/v[89].S to make progress. >

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread H.J. Lu
On Thu, Jan 15, 2015 at 8:40 AM, Rainer Orth wrote: > Richard Henderson writes: > >> Upstream libffi has added support for Go closures (using the static chain), >> and support for complex numbers. Perhaps less relevant is new support for >> arc, microblaze, moxie, nios, and or1k targets. >> >> W

Re: [COMMITTED] Merge libffi with upstream

2015-01-15 Thread Rainer Orth
Richard Henderson writes: > Upstream libffi has added support for Go closures (using the static chain), > and support for complex numbers. Perhaps less relevant is new support for > arc, microblaze, moxie, nios, and or1k targets. > > Without additional changes for Go, this merge has little effec

Re: [COMMITTED] Merge libffi with upstream

2015-01-14 Thread H.J. Lu
On Mon, Jan 12, 2015 at 8:34 AM, Richard Henderson wrote: > Upstream libffi has added support for Go closures (using the static chain), > and support for complex numbers. Perhaps less relevant is new support for > arc, microblaze, moxie, nios, and or1k targets. > > Without additional changes for

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread Richard Henderson
On 01/12/2015 11:08 AM, Uros Bizjak wrote: > Hello! > >> Upstream libffi has added support for Go closures (using the static chain), >> and support for complex numbers. Perhaps less relevant is new support for >> arc, microblaze, moxie, nios, and or1k targets. >> >> Without additional changes for

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread H.J. Lu
On Mon, Jan 12, 2015 at 2:31 PM, H.J. Lu wrote: > On Mon, Jan 12, 2015 at 11:08 AM, Uros Bizjak wrote: >> Hello! >> >>> Upstream libffi has added support for Go closures (using the static chain), >>> and support for complex numbers. Perhaps less relevant is new support for >>> arc, microblaze, m

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread Dominique Dhumieres
> ... Due to upstream breakage, and difficulty debugging on Darwin, > {i686,x86_64}-darwin retains copies of the existing sources and thus remains > 100% unchanged. ... Nevertheless the commit breaks bootstrap on darwin: ... libtool: link: /opt/gcc/build_w/./gcc/xgcc -B/opt/gcc/build_w/./gcc/ -B

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread H.J. Lu
On Mon, Jan 12, 2015 at 11:08 AM, Uros Bizjak wrote: > Hello! > >> Upstream libffi has added support for Go closures (using the static chain), >> and support for complex numbers. Perhaps less relevant is new support for >> arc, microblaze, moxie, nios, and or1k targets. >> >> Without additional c

Re: [COMMITTED] Merge libffi with upstream

2015-01-12 Thread Uros Bizjak
Hello! > Upstream libffi has added support for Go closures (using the static chain), > and support for complex numbers. Perhaps less relevant is new support for > arc, microblaze, moxie, nios, and or1k targets. > > Without additional changes for Go, this merge has little effect. Within the > gcc