Re: [COMMITTED/13] Fix PR 110386: backprop vs ABSU_EXPR

2024-05-09 Thread Andrew Pinski
On Sun, Oct 1, 2023 at 12:28 PM Andrew Pinski wrote: > > From: Andrew Pinski > > The issue here is that when backprop tries to go > and strip sign ops, it skips over ABSU_EXPR but > ABSU_EXPR not only does an ABS, it also changes the > type to unsigned. > Since strip_sign_op_1 is only supposed to

[COMMITTED/13] Fix PR 110386: backprop vs ABSU_EXPR

2023-10-01 Thread Andrew Pinski
From: Andrew Pinski The issue here is that when backprop tries to go and strip sign ops, it skips over ABSU_EXPR but ABSU_EXPR not only does an ABS, it also changes the type to unsigned. Since strip_sign_op_1 is only supposed to strip off sign changing operands and not ones that change types, rem