Re: [COMMITED] [lto] ipcp don't propagate where not needed

2024-11-27 Thread Martin Jambor
On Wed, Nov 06 2024, Michal Jires wrote: > On Wed, 2024-11-06 at 17:33:50 +, Jonathan Wakely wrote: >> >> If there's going to be a constructor then it should initialize the members. >> >> Otherwise, your original patch was better, because you could write >> this to get an all-zeros object: >>

Re: [COMMITED] [lto] ipcp don't propagate where not needed

2024-11-06 Thread Jonathan Wakely
On Wed, 6 Nov 2024 at 18:39, Michal Jires wrote: > > On Wed, 2024-11-06 at 17:33:50 +, Jonathan Wakely wrote: > > > > If there's going to be a constructor then it should initialize the members. > > > > Otherwise, your original patch was better, because you could write > > this to get an all-ze

Re: [COMMITED] [lto] ipcp don't propagate where not needed

2024-11-06 Thread Michal Jires
On Wed, 2024-11-06 at 17:33:50 +, Jonathan Wakely wrote: > > If there's going to be a constructor then it should initialize the members. > > Otherwise, your original patch was better, because you could write > this to get an all-zeros object: > > lto_encoder_entry e{}; > > Now you can't s

Re: [COMMITED] [lto] ipcp don't propagate where not needed

2024-11-06 Thread Jonathan Wakely
On 06/11/24 13:39 +0100, Michal Jires wrote: Commited with suggested changes. - This patch disables propagation of ipcp information into partitions where all instances of the node are marked to be inlined. Motivation: Incremen

[COMMITED] [lto] ipcp don't propagate where not needed

2024-11-06 Thread Michal Jires
Commited with suggested changes. - This patch disables propagation of ipcp information into partitions where all instances of the node are marked to be inlined. Motivation: Incremental LTO needs stable values between compilation