Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-28 Thread Jan Hubicka
> Ping I am really sorry for ignoring this so long - I would like to reorg the code and replace instrumentaiton thunks by the notion of transparent aliases, but did not have time to do that yet. Have quite busy time now. > >>> > >>> 2015-04-14 Ilya Enkovich > >>> > >>> * ipa.c (symbol_

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-26 Thread Ilya Enkovich
Ping 2015-05-19 12:40 GMT+03:00 Ilya Enkovich : > Ping > > 2015-05-05 11:06 GMT+03:00 Ilya Enkovich : >> Ping >> >> 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : >>> On 10 Apr 03:15, Jan Hubicka wrote: > > References are not streamed out for nodes which are referenced in a > partition

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-19 Thread Ilya Enkovich
Ping 2015-05-05 11:06 GMT+03:00 Ilya Enkovich : > Ping > > 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : >> On 10 Apr 03:15, Jan Hubicka wrote: >>> > >>> > References are not streamed out for nodes which are referenced in a >>> > partition but don't belong to it ('continue' condition in output_refs >

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-05-05 Thread Ilya Enkovich
Ping 2015-04-14 12:14 GMT+03:00 Ilya Enkovich : > On 10 Apr 03:15, Jan Hubicka wrote: >> > >> > References are not streamed out for nodes which are referenced in a >> > partition but don't belong to it ('continue' condition in output_refs >> > loop). >> >> Yeah, but it already special cases aliase

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-14 Thread Ilya Enkovich
On 10 Apr 03:15, Jan Hubicka wrote: > > > > References are not streamed out for nodes which are referenced in a > > partition but don't belong to it ('continue' condition in output_refs > > loop). > > Yeah, but it already special cases aliases (because we now always preserve > IPA_REF_ALIAS link

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-06 Thread Ilya Enkovich
2015-04-03 21:49 GMT+03:00 Jan Hubicka : >> Assembler name of instrumented function is a transparent alias of >> original function's name. Alias chains are not taken into account by >> analysis. Thus we see no conflict between instrumented function's name >> and a variable name but emit them with

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-03 Thread Jan Hubicka
> Assembler name of instrumented function is a transparent alias of > original function's name. Alias chains are not taken into account by > analysis. Thus we see no conflict between instrumented function's name > and a variable name but emit them with the same assembler name. To > detect name con

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-03 Thread Ilya Enkovich
2015-04-02 20:01 GMT+03:00 Jan Hubicka : >> Ping > It would help if you add hubi...@ucw.cz to CC for IPA related patches. >> >> 2015-03-19 11:34 GMT+03:00 Ilya Enkovich : >> > On 12 Mar 13:27, Ilya Enkovich wrote: >> >> Hi, >> >> >> >> Currently cgraph merge has several issues with instrumented cod

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-02 Thread Jan Hubicka
> Ping It would help if you add hubi...@ucw.cz to CC for IPA related patches. > > 2015-03-19 11:34 GMT+03:00 Ilya Enkovich : > > On 12 Mar 13:27, Ilya Enkovich wrote: > >> Hi, > >> > >> Currently cgraph merge has several issues with instrumented code: > >> - original function node may be removed

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-02 Thread Ilya Enkovich
Ping 2015-03-19 11:34 GMT+03:00 Ilya Enkovich : > On 12 Mar 13:27, Ilya Enkovich wrote: >> Hi, >> >> Currently cgraph merge has several issues with instrumented code: >> - original function node may be removed => no assembler name conflict is >> detected between function and variable >> - only

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-03-19 Thread Ilya Enkovich
On 12 Mar 13:27, Ilya Enkovich wrote: > Hi, > > Currently cgraph merge has several issues with instrumented code: > - original function node may be removed => no assembler name conflict is > detected between function and variable > - only orig_decl name is privatized for instrumented function =

[CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-03-12 Thread Ilya Enkovich
Hi, Currently cgraph merge has several issues with instrumented code: - original function node may be removed => no assembler name conflict is detected between function and variable - only orig_decl name is privatized for instrumented function => node still shares assembler name which causes i