Re: [C PATCH] fix column number in comma expression warning

2014-04-19 Thread Prathamesh Kulkarni
I had sent this patch during stage-3 of gcc-4.9. Is the patch OK ? On Thu, Feb 20, 2014 at 6:26 PM, Marek Polacek wrote: > On Thu, Feb 20, 2014 at 05:52:09PM +0530, Prathamesh Kulkarni wrote: >> Show column number of left operand instead of comma operator >> in the warning "left-hand operand of c

Re: [C PATCH] fix column number in comma expression warning

2014-02-20 Thread Prathamesh Kulkarni
On Thu, Feb 20, 2014 at 6:26 PM, Marek Polacek wrote: > On Thu, Feb 20, 2014 at 05:52:09PM +0530, Prathamesh Kulkarni wrote: >> Show column number of left operand instead of comma operator >> in the warning "left-hand operand of comma expression has no effect" >> >> Example: >> ax.c:4:6: warning:

Re: [C PATCH] fix column number in comma expression warning

2014-02-20 Thread Marek Polacek
On Thu, Feb 20, 2014 at 05:52:09PM +0530, Prathamesh Kulkarni wrote: > Show column number of left operand instead of comma operator > in the warning "left-hand operand of comma expression has no effect" > > Example: > ax.c:4:6: warning: left-hand operand of comma expression has no effect > [-Wunus

[C PATCH] fix column number in comma expression warning

2014-02-20 Thread Prathamesh Kulkarni
Show column number of left operand instead of comma operator in the warning "left-hand operand of comma expression has no effect" Example: ax.c:4:6: warning: left-hand operand of comma expression has no effect [-Wunused-value] x , y; ^ Instead of comma operator, show location of left-op