Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-22 Thread Joseph S. Myers
On Mon, 21 Oct 2013, Marek Polacek wrote: > Tested via make check -C gcc RUNTESTFLAGS=dg.exp=c1x-*.c, ok for > trunk? > > 2013-10-21 Marek Polacek > > c/ > * c-parser.c (c_parser_struct_declaration): Add a comment. > (c_parser_declarator): Don't allow _Alignas here. > testsuite/ >

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-21 Thread Marek Polacek
On Sat, Oct 19, 2013 at 07:23:20PM +, Joseph S. Myers wrote: > On Wed, 16 Oct 2013, Marek Polacek wrote: > > > @@ -2946,7 +2957,8 @@ c_parser_declarator (c_parser *parser, b > >struct c_declspecs *quals_attrs = build_null_declspecs (); > >struct c_declarator *inner; > >

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-19 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Marek Polacek wrote: > @@ -2946,7 +2957,8 @@ c_parser_declarator (c_parser *parser, b >struct c_declspecs *quals_attrs = build_null_declspecs (); >struct c_declarator *inner; >c_parser_consume_token (parser); > - c_parser_declspecs (parser, quals_a

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Marek Polacek wrote: > Regtested/bootstrapped on x86_64-linux, ok for trunk? > > 2013-10-16 Marek Polacek > > PR c/58267 > c/ > * c-parser.c (c_parser_declspecs): Add alignspec_ok parameter. > Document syntax of the array-declarator. > (c_parser_de

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Marek Polacek
On Wed, Oct 16, 2013 at 12:28:32PM +, Joseph S. Myers wrote: > On Wed, 16 Oct 2013, Marek Polacek wrote: > > > This PR is about _Alignas in contexts like > > char x[_Alignas (int) 20]; > > C grammar does not allow _Alignas to be in an array declarator, yet we > > don't issue any warning or an

Re: [C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Joseph S. Myers
On Wed, 16 Oct 2013, Marek Polacek wrote: > This PR is about _Alignas in contexts like > char x[_Alignas (int) 20]; > C grammar does not allow _Alignas to be in an array declarator, yet we > don't issue any warning or an error. This patch implements a pedwarn > for this. I'm however highly unsur

[C PATCH] Warn for _Alignas in an array declarator (PR c/58267)

2013-10-16 Thread Marek Polacek
This PR is about _Alignas in contexts like char x[_Alignas (int) 20]; C grammar does not allow _Alignas to be in an array declarator, yet we don't issue any warning or an error. This patch implements a pedwarn for this. I'm however highly unsure whether we want pedwarn, error, or normal warning f