Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-05-11 Thread Mikhail Maltsev
On 05/10/2016 10:51 PM, Joseph Myers wrote: > On Sat, 9 Apr 2016, Mikhail Maltsev wrote: > >> gcc/c/ChangeLog: >> >> 2016-04-08 Mikhail Maltsev >> >> PR c/43651 >> * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifier >> is enabled. >> * c-errors.

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-05-10 Thread Joseph Myers
On Sat, 9 Apr 2016, Mikhail Maltsev wrote: > gcc/c/ChangeLog: > > 2016-04-08 Mikhail Maltsev > > PR c/43651 > * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifier > is enabled. > * c-errors.c (pedwarn_c90): Return true if warned. > * c-

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-10 Thread Martin Sebor
On 04/09/2016 06:28 AM, Mikhail Maltsev wrote: On 04/08/2016 08:54 PM, Martin Sebor wrote: The name for new option "-Wduplicate-decl-specifier" and wording was chosen to match the same option in Clang. My version of Clang also warns in C++ mode but if I'm reading the patch right, GCC would war

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-09 Thread Mikhail Maltsev
On 04/08/2016 08:54 PM, Martin Sebor wrote: >> The name for new option "-Wduplicate-decl-specifier" and wording was >> chosen to match the same option in Clang. > > My version of Clang also warns in C++ mode but if I'm reading > the patch right, GCC would warn only C mode. I would find it > surpr

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-08 Thread Martin Sebor
On 04/04/2016 04:29 AM, Mikhail Maltsev wrote: Hi all! Currently GCC produces pedantic warning, if variable declaration (or typedef) has duplicate qualifier, but only when compiling as C89 (not C99 or C11). Presumably that's because C89 makes duplicating a type qualifier a constraint violation

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-08 Thread Mikhail Maltsev
On 04/08/2016 12:50 AM, Joseph Myers wrote: > New options need documenting in invoke.texi. > Done. -- Regards, Mikhail Maltsev gcc/c/ChangeLog: 2016-04-08 Mikhail Maltsev PR c/43651 * c-decl.c (declspecs_add_qual): Warn when -Wduplicate-decl-specifier is enabled

Re: [C PATCH] PR43651: add warning for duplicate qualifier

2016-04-07 Thread Joseph Myers
New options need documenting in invoke.texi. -- Joseph S. Myers jos...@codesourcery.com

[C PATCH] PR43651: add warning for duplicate qualifier

2016-04-04 Thread Mikhail Maltsev
Hi all! Currently GCC produces pedantic warning, if variable declaration (or typedef) has duplicate qualifier, but only when compiling as C89 (not C99 or C11). The attached patch adds a new warning option to enable the same warning in C99 and C11. It also checks whether qualifiers come from macro