Re: [C PATCH] Fix set_nonincremental_init_from_string (PR c/67410)

2016-08-12 Thread Marek Polacek
On Fri, Aug 12, 2016 at 05:54:55PM +0200, Jakub Jelinek wrote: > Hi! > > The wide-int conversion of set_nonincremental_init_from_string broke this > function. > Before we used val[bitpos < HOST_BITS_PER_WIDE_INT], but val[1] and val[0] > has been swapped, so either it should be bitpos >= HOST_BITS

Re: [C PATCH] Fix set_nonincremental_init_from_string (PR c/67410)

2016-08-12 Thread Joseph Myers
On Fri, 12 Aug 2016, Jakub Jelinek wrote: > Hi! > > The wide-int conversion of set_nonincremental_init_from_string broke this > function. > Before we used val[bitpos < HOST_BITS_PER_WIDE_INT], but val[1] and val[0] > has been swapped, so either it should be bitpos >= HOST_BITS_PER_WIDE_INT, > or

[C PATCH] Fix set_nonincremental_init_from_string (PR c/67410)

2016-08-12 Thread Jakub Jelinek
Hi! The wide-int conversion of set_nonincremental_init_from_string broke this function. Before we used val[bitpos < HOST_BITS_PER_WIDE_INT], but val[1] and val[0] has been swapped, so either it should be bitpos >= HOST_BITS_PER_WIDE_INT, or bitpos / HOST_BITS_PER_WIDE_INT. Bootstrapped/regtested