Re: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization

2012-04-21 Thread Manuel López-Ibáñez
I created PR 53061 to track this. I prefer to focus on other things, so feel free to take the patch there and do whatever you need to get it approved. Cheers, Manuel.

Re: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization

2012-04-09 Thread Gabriel Dos Reis
On Mon, Apr 9, 2012 at 6:19 AM, Manuel López-Ibáñez wrote: > On 9 April 2012 12:43, Gabriel Dos Reis wrote: >> On Mon, Apr 9, 2012 at 5:12 AM, Manuel López-Ibáñez >> wrote: >>>        * c-common.h (c_common_initialize_diagnostics): Likewise. >> >> Make the comment less personal; we don't who "I"

Re: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization

2012-04-09 Thread Manuel López-Ibáñez
On 9 April 2012 12:43, Gabriel Dos Reis wrote: > On Mon, Apr 9, 2012 at 5:12 AM, Manuel López-Ibáñez > wrote: >>        * c-common.h (c_common_initialize_diagnostics): Likewise. > > Make the comment less personal; we don't who "I" is in "I'm putting them here" > in three months (nor should we hav

Re: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization

2012-04-09 Thread Gabriel Dos Reis
On Mon, Apr 9, 2012 at 5:12 AM, Manuel López-Ibáñez wrote: > This patch cleans up the diagnostic initialization of the C-family > FEs. It keeps the default of no line-wrapping. It moves together all > initializations and deletes code that has no effect. > > Bootstrapped and regression tested on x8

[C/ObjC/C++/ObjC++] cleanup diagnostics initialization

2012-04-09 Thread Manuel López-Ibáñez
This patch cleans up the diagnostic initialization of the C-family FEs. It keeps the default of no line-wrapping. It moves together all initializations and deletes code that has no effect. Bootstrapped and regression tested on x86-unknown-linux-gnu with enable-languages=all,ada,obj-c++. OK? 201