Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120) | Fix declare copyout in libgomp.oacc-c++/declare-pr94120.C

Hi Thomas, I have now fixed it temporarily differently – without actually testing that feature. – See attachment. For the proper fix, it would help to get the semantic right in OpenACC itself (→ ongoing discussion). I think the patch for PR94120 is probably not completely right – and should be f

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

Hi Tobias! I do see the new 'libgomp.oacc-c++/declare-pr94120.C' (see below, for reference) FAIL for '-foffload=nvptx-none' execution testing. The reason is that the 'C' array doesn't have the content it's checked to have. Now, my question, shouldn't it be changed like the attached patch, or sim

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

Hi Tobias! On 2020-04-08T09:55:24+0200, Tobias Burnus wrote: > I have now committed this patch > as r10-7614-g13e41d8b9d3d7598c72c38acc86a3d97046c8373, > reading "so we shall accept it" as approval … That's OK. As I said: "I'm not at all familiar with the front ends' scoping implementation", an

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

There was a glitch in the test case (location + dg-error), already fixed by Jakub (thanks!) in commit r10-7637-g08d1e7a5aabcf7eeac48bfd99deb80451b8f9974 Sorry, Tobias On 4/8/20 7:13 PM, H.J. Lu wrote: On Wed, Apr 8, 2020 at 12:55 AM Tobias Burnus wrote: I have now committed this patch as r1

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

On Wed, Apr 8, 2020 at 12:55 AM Tobias Burnus wrote: > > I have now committed this patch > as r10-7614-g13e41d8b9d3d7598c72c38acc86a3d97046c8373, On Linux/x86, I got FAIL: g++.dg/declare-pr94120.C -std=c++14 (test for excess errors) FAIL: g++.dg/declare-pr94120.C -std=c++17 (test for excess er

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

I have now committed this patch as r10-7614-g13e41d8b9d3d7598c72c38acc86a3d97046c8373, reading "so we shall accept it" as approval … On 4/1/20 9:07 AM, Thomas Schwinge wrote: Even if the ICE is then fixed, should we still keep open (with a note) until

Re: *PING**2 Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

Hi Tobias! On 2020-04-07T09:21:27+0200, Tobias Burnus wrote: > *PING**2 <87h7y3ofad.fsf@euler.schwinge.homeip.net">http://mid.mail-archive.com/87h7y3ofad.fsf@euler.schwinge.homeip.net>? Grüße Thomas - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / German

*PING**2 Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

*PING**2 On 3/24/20 11:18 AM, Tobias Burnus wrote: On 3/11/20 2:28 PM, Tobias Burnus wrote: Fortran patch: https://gcc.gnu.org/pipermail/gcc-patches/current/541774.html Like for Fortran, it also fixes some other issues – here for C++ related to namespaces. (For class, see PR c++/94140.) Test

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

; So - just to be sure - the new namespace condition subsumes the old > "global_bindings_p" condition because the global scope is also a namespace, > right? Yes, now I see that you have a test case that demonstrates that > the declare directive still works for global variables

*PING* Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

On 3/11/20 2:28 PM, Tobias Burnus wrote: Fortran patch: https://gcc.gnu.org/pipermail/gcc-patches/current/541774.html Like for Fortran, it also fixes some other issues – here for C++ related to namespaces. (For class, see PR c++/94140.) Test case of the PR yields an ICE in the middle end and th

Re: [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

Tobias Burnus writes: Hi Tobias, > Fortran patch: https://gcc.gnu.org/pipermail/gcc-patches/current/541774.html > > "A declare directive must be in the same scope > as the declaration of any var that appears in > the data clauses of the directive." > > ("A declare directive is used […] follo

[C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120)

chland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter [C/C++, OpenACC] Reject vars of different scope in acc declare (PR94120) 2020-10-11 Tobias Burnus gcc/c/ PR middle-end/94120 * c-decl.c (c_chec