Re: [C++ patch] PR 65858

2015-05-01 Thread Jason Merrill
OK (= true). Jason

Re: [C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
On 1 May 2015 at 01:12, Paolo Carlini wrote: > Hi again, > > On 04/30/2015 08:45 PM, Paolo Carlini wrote: >> >> .. also, your patch doesn't seem to fix the case of -w instead of That could be fixed as follows: if (!warn_narrowing || inhibit_warnings) ok = true; else // pedwarn >> -Wno-narrowin

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
Hi again, On 04/30/2015 08:45 PM, Paolo Carlini wrote: .. also, your patch doesn't seem to fix the case of -w instead of -Wno-narrowing. I think we want to check the return value of the pedwarn instead. I'm testing something. I'm finishing testing the below: with hindsight, checking the return

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
.. also, your patch doesn't seem to fix the case of -w instead of -Wno-narrowing. I think we want to check the return value of the pedwarn instead. I'm testing something. Paolo.

Re: [C++ patch] PR 65858

2015-04-30 Thread Paolo Carlini
Hi, On 04/30/2015 06:36 PM, Prathamesh Kulkarni wrote: Hi, The attached patch fixes ICE in PR65858. For the test-case: int x { 0.5 }; Eventually, we have to add to the testsuite the testcase too (the code is simpler but equivalent to what we added for 65801, -flto makes all the difference). A

[C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
Hi, The attached patch fixes ICE in PR65858. For the test-case: int x { 0.5 }; int main() { return 0; } Compiling with: g++ -flto -Wno-narrowing -std=gnu++11 results in following ICE: lto1: internal compiler error: in get_constructor, at varpool.c:331 0xd22f73 varpool_node::get_constructor() ../.