Re: [C++ patch] PR 59482

2014-01-23 Thread Paolo Carlini
Hi, On 01/22/2014 11:38 PM, Ville Voutilainen wrote: Oh, I was expecting Jason would do that. Note that Marek Polacek pointed out two formatting issues: - comments should have full stop and two spaces at the end Yes, will fix in my next commit touching that file. - also two spaces before in t

Re: [C++ patch] PR 59482

2014-01-22 Thread Ville Voutilainen
On 22 January 2014 19:39, Paolo Carlini wrote: > On 01/21/2014 04:24 PM, Jason Merrill wrote: >> >> OK, thanks. > > I don't think Ville has Write After Approval, thus I'm going to commit this > on his behalf. Oh, I was expecting Jason would do that. Note that Marek Polacek pointed out two format

Re: [C++ patch] PR 59482

2014-01-22 Thread Paolo Carlini
On 01/21/2014 04:24 PM, Jason Merrill wrote: OK, thanks. I don't think Ville has Write After Approval, thus I'm going to commit this on his behalf. Thanks, Paolo.

[C++ patch] PR 59482

2014-01-21 Thread Ville Voutilainen
As analysed in the bug report, the scope for the accessibility check was incorrect, and hence the friend was not allowed access. Fixed by pushing into the class scope before parsing the base-clause, and popping afterwards to let the surrounding nested-name-specifier popping work correctly. Tested

Re: [C++ patch] PR 59482

2014-01-21 Thread Jason Merrill
OK, thanks. Jason