On Thu, Sep 13, 2012 at 9:00 AM, Paolo Carlini wrote:
> On 09/11/2012 06:53 PM, Gabriel Dos Reis wrote:
>>
>> On Tue, Sep 11, 2012 at 10:37 AM, Jakub Jelinek wrote:
>>>
>>> On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
PS: slightly interesting, in a couple of cases -
>>
On 09/11/2012 06:53 PM, Gabriel Dos Reis wrote:
On Tue, Sep 11, 2012 at 10:37 AM, Jakub Jelinek wrote:
On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
PS: slightly interesting, in a couple of cases -
write_unnamed_type_name, wrap_cleanups_r - the parameters were
actually used.
On 09/12/2012 10:57 AM, Richard Guenther wrote:
And note that we have ARG_UNUSED for parameters - to cope with older
compilers not handling attributes here too well (I run into this when
using gcc 3.3 as host compiler).
Ah, thanks, I didn't know that (both the problem and the solution): it
seem
On Tue, Sep 11, 2012 at 5:37 PM, Jakub Jelinek wrote:
> On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
>> PS: slightly interesting, in a couple of cases -
>> write_unnamed_type_name, wrap_cleanups_r - the parameters were
>> actually used.
>
> Just a general comment, often an argume
On Tue, Sep 11, 2012 at 10:37 AM, Jakub Jelinek wrote:
> On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
>> PS: slightly interesting, in a couple of cases -
>> write_unnamed_type_name, wrap_cleanups_r - the parameters were
>> actually used.
>
> Just a general comment, often an argum
On 09/11/2012 05:37 PM, Jakub Jelinek wrote:
On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
PS: slightly interesting, in a couple of cases -
write_unnamed_type_name, wrap_cleanups_r - the parameters were
actually used.
Just a general comment, often an argument is only conditiona
On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
> PS: slightly interesting, in a couple of cases -
> write_unnamed_type_name, wrap_cleanups_r - the parameters were
> actually used.
Just a general comment, often an argument is only conditionally used,
e.g. depending on some preproces
Hi,
since we are now using C++, I think we can remove the attributes and
just use unnamed parameters. For now I kept the names in comments for
documentation purposes, but would be glad to remove those too, if you like.
Booted and tested x86_64-linux.
Thanks,
Paolo.
PS: slightly interesting,
