Re: [C++ Patch] PR 71737

2017-02-09 Thread Jason Merrill
On Thu, Feb 9, 2017 at 4:08 AM, Paolo Carlini wrote: > On 14/01/2017 15:43, Jason Merrill wrote: >> >> OK. > > As you may or may not have noticed, I had to revert the patch because it > caused the regression of > tr1/2_general_utilities/shared_ptr/cons/43820_neg.cc during error recovery: > an ICE

Re: [C++ Patch] PR 71737

2017-02-09 Thread Paolo Carlini
Hi again, On 14/01/2017 15:43, Jason Merrill wrote: OK. As you may or may not have noticed, I had to revert the patch because it caused the regression of tr1/2_general_utilities/shared_ptr/cons/43820_neg.cc during error recovery: an ICE happens in remap_decl when build_variant_type_copy is c

Re: [C++ Patch] PR 71737

2017-01-16 Thread Paolo Carlini
On 16/01/2017 16:11, David Edelsohn wrote: This patch caused a libstdc++ regression on AIX libstdc++-v3/include/tr1/shared_ptr.h:556: internal compiler error: tree check: expected class 'type', have 'exceptional' (error_mark) in build_variant_type_copy, at tree.c:6737 I noticed, patch reverted

Re: [C++ Patch] PR 71737

2017-01-16 Thread David Edelsohn
This patch caused a libstdc++ regression on AIX libstdc++-v3/include/tr1/shared_ptr.h:556: internal compiler error: tree check: expected class 'type', have 'exceptional' (error_mark) in build_variant_type_copy, at tree.c:6737

Re: [C++ Patch] PR 71737

2017-01-14 Thread Jason Merrill
OK. On Fri, Jan 13, 2017 at 5:58 PM, Paolo Carlini wrote: > Hi, > > On 13/01/2017 18:33, Jason Merrill wrote: >> >> On Fri, Jan 13, 2017 at 11:42 AM, Paolo Carlini >> wrote: >>> >>> Hi, >>> >>> On 13/01/2017 15:51, Nathan Sidwell wrote: On 01/13/2017 09:45 AM, Paolo Carlini wrote:

Re: [C++ Patch] PR 71737

2017-01-13 Thread Paolo Carlini
Hi, On 13/01/2017 18:33, Jason Merrill wrote: On Fri, Jan 13, 2017 at 11:42 AM, Paolo Carlini wrote: Hi, On 13/01/2017 15:51, Nathan Sidwell wrote: On 01/13/2017 09:45 AM, Paolo Carlini wrote: Hi, in this error recovery issue get_underlying_template crashes when TYPE_TEMPLATE_INFO_MAYBE_AL

Re: [C++ Patch] PR 71737

2017-01-13 Thread Jason Merrill
On Fri, Jan 13, 2017 at 11:42 AM, Paolo Carlini wrote: > Hi, > > On 13/01/2017 15:51, Nathan Sidwell wrote: >> >> On 01/13/2017 09:45 AM, Paolo Carlini wrote: >>> >>> Hi, >>> >>> in this error recovery issue get_underlying_template crashes when >>> TYPE_TEMPLATE_INFO_MAYBE_ALIAS is applied to a nu

Re: [C++ Patch] PR 71737

2017-01-13 Thread Paolo Carlini
Hi, On 13/01/2017 15:51, Nathan Sidwell wrote: On 01/13/2017 09:45 AM, Paolo Carlini wrote: Hi, in this error recovery issue get_underlying_template crashes when TYPE_TEMPLATE_INFO_MAYBE_ALIAS is applied to a null orig_type. Simply checking for that condition appears to solve the issue in a st

[C++ Patch] PR 71737

2017-01-13 Thread Paolo Carlini
Hi, in this error recovery issue get_underlying_template crashes when TYPE_TEMPLATE_INFO_MAYBE_ALIAS is applied to a null orig_type. Simply checking for that condition appears to solve the issue in a straightforward way. Tested x86_64-linux. Thanks, Paolo. / /cp 2017-01

Re: [C++ Patch] PR 71737

2017-01-13 Thread Nathan Sidwell
On 01/13/2017 09:45 AM, Paolo Carlini wrote: Hi, in this error recovery issue get_underlying_template crashes when TYPE_TEMPLATE_INFO_MAYBE_ALIAS is applied to a null orig_type. Simply checking for that condition appears to solve the issue in a straightforward way. Tested x86_64-linux. Wouldn'