Re: [C++ Patch] PR 54583

2012-10-31 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 54583

2012-10-31 Thread Paolo Carlini
Hi, On 10/31/2012 02:50 PM, Jason Merrill wrote: On 10/30/2012 07:44 PM, Paolo Carlini wrote: straightforward fix. The below, which regtests fine, simply acts on any MULT_EXPR as TYPE_SIZE, which I think should be fine, but, in case the idea is basically Ok, we could also consider the more comp

Re: [C++ Patch] PR 54583

2012-10-31 Thread Jason Merrill
On 10/30/2012 07:44 PM, Paolo Carlini wrote: straightforward fix. The below, which regtests fine, simply acts on any MULT_EXPR as TYPE_SIZE, which I think should be fine, but, in case the idea is basically Ok, we could also consider the more complex but more sophisticated variably_modified_type_p

[C++ Patch] PR 54583

2012-10-30 Thread Paolo Carlini
Hi, this diagnostic issue is about spurious "value computed is not used" warnings with VLAs, emitted by convert_to_void (on the TYPE_SIZE, a MULT_EXPR): the warning is already gated by !TREE_NO_WARNING (expr) thus setting it at the end of build_cplus_array_type seems a rather straightforward