Re: [C++ Patch] PR 51326

2011-12-03 Thread Dodji Seketeli
Jason Merrill a écrit: > On 12/03/2011 04:25 PM, Dodji Seketeli wrote: >> This might be a theoretical nit, but it looks like if expr is >> error_mark_node, we'd crash as well, because of the line below that comes >> right after the comment above: >> >>gcc_assert (!MAYBE_CLASS_TYPE_P (fromtype

Re: [C++ Patch] PR 51326

2011-12-03 Thread Jason Merrill
On 12/03/2011 04:25 PM, Dodji Seketeli wrote: This might be a theoretical nit, but it looks like if expr is error_mark_node, we'd crash as well, because of the line below that comes right after the comment above: gcc_assert (!MAYBE_CLASS_TYPE_P (fromtype) || !MAYBE_CLASS_TYPE_P (totype)

Re: [C++ Patch] PR 51326

2011-12-03 Thread Dodji Seketeli
Hello Paolo, Paolo Carlini a écrit: > Index: cp/call.c > === > --- cp/call.c (revision 181875) > +++ cp/call.c (working copy) > @@ -3373,7 +3373,7 @@ static struct z_candidate * > build_user_type_conversion_1 (tree totype, tree exp

Re: [C++ Patch] PR 51326

2011-12-01 Thread Jason Merrill
OK. Jason

[C++ Patch] PR 51326

2011-12-01 Thread Paolo Carlini
Hi, in this ICE on invalid, 4.7 Regression, we ICE at the beginning of build_user_type_conversion_1 because expr is NULL_TREE. The function is called as such from reference_binding which, in 4.6, used to call instead convert_class_to_reference which does check for a NULL_TREE expr. Thus I thi