Re: [C++ Patch] PR 30066

2011-10-27 Thread Jason Merrill
I made a few formatting tweaks as follows, and checked in the patch. Thanks! Jason commit 3e01e07381cdb16727fe6011202372ebcdfc Author: Jason Merrill Date: Thu Oct 27 17:44:39 2011 -0400 cleanup diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 1e514af..be9044b 100644 --- a/gcc/cp/d

Re: [C++ Patch] PR 30066

2011-10-25 Thread Roberto Agostino Vitillo
The new testcase: Index: gcc/testsuite/g++.dg/ext/visibility/fvisibility-inlines-hidden-4.C === --- gcc/testsuite/g++.dg/ext/visibility/fvisibility-inlines-hidden-4.C (revision 0) +++ gcc/testsuite/g++.dg/ext/visibility/fvisibility-

Re: [C++ Patch] PR 30066

2011-10-24 Thread Roberto Agostino Vitillo
The comment is still valid now. r gcc/Changelog: 2011-10-25 Roberto Agostino Vitillo PR c++/30066 * doc/invoke.texi (fvisibility-inlines-hidden): Documentation change. gcc/c-family/Changelog: 2011-10-25 Roberto Agostino Vitillo PR c++/30066 * c.opt (fvisi

Re: [C++ Patch] PR 30066

2011-10-21 Thread Jason Merrill
Need to make sure that this comment is still accurate: /* Local statics and classes get the visibility of their containing function by default, except that -fvisibility-inlines-hidden doesn't affect them. */ i.e. given inline int * f() { static int i; retu

Re: [C++ Patch] PR 30066

2011-10-21 Thread Roberto Agostino Vitillo
I am resubmitting the changelog since it was not respecting the conventions. gcc/Changelog: 2011-10-21 Roberto Agostino Vitillo PR c++/30066 * doc/invoke.texi (fvisibility-inlines-hidden): Documentation change. gcc/c-family/Changelog: 2011-10-21 Roberto Agostino Vitillo

[C++ Patch] PR 30066

2011-10-21 Thread Roberto Agostino Vitillo
With this patch fvisibility-inlines-hidden affects also inline functions, e.g.: inline void foo() {} int main(){ foo(); return 0; } when compiled with -fvisibility-inlines-hidden, foo has hidden visibility: ... 10: 6 FUNCWEAK HIDDEN 6 _Z3foov ... Tested