Re: [C++ Patch] More accurate location for conditional expressions

2013-05-22 Thread Paolo Carlini
Andreas Schwab ha scritto: >Paolo Carlini writes: > >> * call.c (build_conditional_expr_1): Add location_t parameter. >> (build_conditional_expr): Likewise. Argh, I'll fix it momentarily sorry. I admit I forgot to enable objc and obj-c++ when testing. Paolo

Re: [C++ Patch] More accurate location for conditional expressions

2013-05-22 Thread Andreas Schwab
Paolo Carlini writes: > * call.c (build_conditional_expr_1): Add location_t parameter. > (build_conditional_expr): Likewise. ../../gcc/objc/objc-next-runtime-abi-02.c: In function 'tree_node* build_v2_build_objc_method_call(int, tree, tree, tree, tree, bool)': ../../gcc/objc/objc-ne

Re: [C++ Patch] More accurate location for conditional expressions

2013-05-21 Thread Jason Merrill
On 05/21/2013 06:13 AM, Paolo Carlini wrote: @@ -2141,7 +2141,8 @@ rationalize_conditional_expr (enum tree_code code, gcc_assert (!TREE_SIDE_EFFECTS (op0) && !TREE_SIDE_EFFECTS (op1)); return - build_conditional_expr (build_x_binary_op (input_location, +

[C++ Patch] More accurate location for conditional expressions

2013-05-21 Thread Paolo Carlini
Hi, a little more work on locations. Yesterday, when I patched build_new_op_1 to propagate the incoming location to cp_build_binary_op I noticed that the locations for the conditional expressions in Wdouble-promotion.C where inaccurate, essentially always pointing to the end. We can improve t