Re: [C++ Patch] Mini bunch of mini clean-ups

2013-04-01 Thread Jason Merrill
On 04/01/2013 01:11 PM, Paolo Carlini wrote: We have an ICE for g++.dg/template/qualttp17.C. Is this something we want to further investigate now or shall I just leave the check in? Leave the check. The patch is OK. Jason

Re: [C++ Patch] Mini bunch of mini clean-ups

2013-04-01 Thread Paolo Carlini
Hi again On 04/01/2013 06:55 PM, Paolo Carlini wrote: Hi, On 04/01/2013 06:50 PM, Jason Merrill wrote: On 04/01/2013 12:41 PM, Paolo Carlini wrote: +#define DECL_FUNCTION_TEMPLATE_P(NODE) \ + (TREE_CODE (NODE) == TEMPLATE_DECL \ + && DECL_TEMPLATE_RESULT (NODE) !=

Re: [C++ Patch] Mini bunch of mini clean-ups

2013-04-01 Thread Paolo Carlini
Hi, On 04/01/2013 06:50 PM, Jason Merrill wrote: On 04/01/2013 12:41 PM, Paolo Carlini wrote: +#define DECL_FUNCTION_TEMPLATE_P(NODE) \ + (TREE_CODE (NODE) == TEMPLATE_DECL \ + && DECL_TEMPLATE_RESULT (NODE) != NULL_TREE\ Do we need the NULL_TREE check?

Re: [C++ Patch] Mini bunch of mini clean-ups

2013-04-01 Thread Jason Merrill
On 04/01/2013 12:41 PM, Paolo Carlini wrote: +#define DECL_FUNCTION_TEMPLATE_P(NODE) \ + (TREE_CODE (NODE) == TEMPLATE_DECL\ + && DECL_TEMPLATE_RESULT (NODE) != NULL_TREE \ Do we need the NULL_TREE check? That is, do we st

[C++ Patch] Mini bunch of mini clean-ups

2013-04-01 Thread Paolo Carlini
Hi, three items: - Remove DECL_UNBOUND_CLASS_TEMPLATE_P, unused outside cp-tree.h. - Use get_containing_scope in 4 places (obvious I guess) - Use existing predicates in 2 places (likewise) Tested x86_64-linux. Ok? Thanks, Paolo. PS: In my opinion we should also rename DECL_FUNCTION_MEMBER_P to