Re: [C++ Patch/RFC] Tiny tsubst tweak

2016-06-08 Thread Jason Merrill
The first patch is OK. Jason

Re: [C++ Patch/RFC] Tiny tsubst tweak

2016-06-08 Thread Paolo Carlini
... well, I suppose that in principle the super-safe thing to do in such cases would be checking immediately and returning immediately only if we are in a SFINAE context. Like in the untested patchlet attached. Paolo. / Index: pt.c ==

[C++ Patch/RFC] Tiny tsubst tweak

2016-06-08 Thread Paolo Carlini
Hi, while looking a bit into c++/71169 I noticed that in one place we first call tsubst_aggr_type and tubst_copy and then we check if either returned error_mark_node. Performance-wise, it would be better to check as soon as possible the return value of the former and in case return immediatel