Re: [C++ PATCH] vfunc overrider simplification

2019-08-26 Thread Nathan Sidwell
On 8/25/19 2:35 PM, Jason Merrill wrote: On Sat, Aug 24, 2019 at 6:43 PM Nathan Sidwell > wrote: On 8/23/19 3:24 PM, Nathan Sidwell wrote: > In fixing a vfunc override bug on the modules branch, I noticed that > check_for_override can simply check IDENTIFIER_

Re: [C++ PATCH] vfunc overrider simplification

2019-08-25 Thread Jason Merrill
On Sat, Aug 24, 2019 at 6:43 PM Nathan Sidwell wrote: > On 8/23/19 3:24 PM, Nathan Sidwell wrote: > > In fixing a vfunc override bug on the modules branch, I noticed that > > check_for_override can simply check IDENTIFIER_VIRTUAL_P -- the dtor > > identifier and those for conversion operators wil

Re: [C++ PATCH] vfunc overrider simplification

2019-08-24 Thread Nathan Sidwell
On 8/23/19 3:24 PM, Nathan Sidwell wrote: In fixing a vfunc override bug on the modules branch, I noticed that check_for_override can simply check IDENTIFIER_VIRTUAL_P -- the dtor identifier and those for conversion operators will have it set correctly.  (there a multiple conversion operator id

[C++ PATCH] vfunc overrider simplification

2019-08-23 Thread Nathan Sidwell
In fixing a vfunc override bug on the modules branch, I noticed that check_for_override can simply check IDENTIFIER_VIRTUAL_P -- the dtor identifier and those for conversion operators will have it set correctly. (there a multiple conversion operator identifiers, but we can only be overriding t