[C++ PATCH] pushdecl

2017-05-23 Thread Nathan Sidwell
This patch reimplements the innards of pushdecl, which deals with local and namespace scope pushing. I managed to collapse or remove a lot of special casing, which I think greatly improves the readability of this piece of code. We're still not onto the performance improvements though. natha

Re: [C++ PATCH] pushdecl and friends

2017-05-11 Thread Nathan Sidwell
On 05/11/2017 02:54 PM, Christophe Lyon wrote: On 11 May 2017 at 20:49, Nathan Sidwell wrote: oh gee. I committed the ChangeLog but not the changed file. just done. I have now ... nathan -- Nathan Sidwell

Re: [C++ PATCH] pushdecl and friends

2017-05-11 Thread Christophe Lyon
On 11 May 2017 at 20:49, Nathan Sidwell wrote: > On 05/11/2017 02:45 PM, Christophe Lyon wrote: > >> >> `/tmp/3713244_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/libcc1' >> >> I suspect it will be an obvious fix? > > > oh gee. I committed the ChangeLog but not the c

Re: [C++ PATCH] pushdecl and friends

2017-05-11 Thread Nathan Sidwell
On 05/11/2017 02:45 PM, Christophe Lyon wrote: `/tmp/3713244_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/libcc1' I suspect it will be an obvious fix? oh gee. I committed the ChangeLog but not the changed file. just done. Hopefully soon the churn will be res

Re: [C++ PATCH] pushdecl and friends

2017-05-11 Thread Christophe Lyon
Hi Nathan On 11 May 2017 at 19:40, Nathan Sidwell wrote: > This patch reduces the variants of pushdecl by use of default arguments. > gone are the _maybe_friend variants. > Since this commit (r247918), GCC builds fail at least for aarch64/arm. I've noticed this error message: libtool: compile:

[C++ PATCH] pushdecl and friends

2017-05-11 Thread Nathan Sidwell
This patch reduces the variants of pushdecl by use of default arguments. gone are the _maybe_friend variants. nathan -- Nathan Sidwell 2017-05-11 Nathan Sidwell * name-lookup.h (pushdecl): Add default friend parm. (pushdecl_maybe_friend): Delete. (pushdecl_top_level): Add default friend

[C++ PATCH] pushdecl

2017-05-08 Thread Nathan Sidwell
This small patch replaces pushdecl_with_scope with a more-specific pushdecl_outermost_localscope. It's used in 2 places to inject an artifical decl into the outermost block scope of a function (__FUNCTION__ var and lambda capture proxies). This moves some binding-level handling into name-look