Re: [C++ PATCH] c++: Poor diagnostic for dynamic_cast in constexpr context [PR93414]

2020-01-25 Thread Marek Polacek
On Fri, Jan 24, 2020 at 10:39:14PM -0500, Jason Merrill wrote: > [C++ PATCH] c++: is unnecessarily redundant, you can just write [PATCH]. True enough, I've dropped --subject-prefix from my git patch alias. > On 1/24/20 6:20 PM, Marek Polacek wrote:> I neglected to add a proper > diagnostic for th

Re: [C++ PATCH] c++: Poor diagnostic for dynamic_cast in constexpr context [PR93414]

2020-01-24 Thread Jason Merrill
[C++ PATCH] c++: is unnecessarily redundant, you can just write [PATCH]. On 1/24/20 6:20 PM, Marek Polacek wrote:> I neglected to add a proper diagnostic for the reference dynamic_cast> case when the operand of a dynamic_cast doesn't refer to a public base> of Derived, resulting in suboptimal

[C++ PATCH] c++: Poor diagnostic for dynamic_cast in constexpr context [PR93414]

2020-01-24 Thread Marek Polacek
I neglected to add a proper diagnostic for the reference dynamic_cast case when the operand of a dynamic_cast doesn't refer to a public base of Derived, resulting in suboptimal error message error: call to non-'constexpr' function 'void* __cxa_bad_cast()' Tested x86_64-linux, ok for trunk? 20