Re: [C++ PATCH] PR c++/88123 - lambda and using-directive.

2019-03-08 Thread Nathan Sidwell
On 3/8/19 10:30 AM, Jason Merrill wrote: The comment for push_operator_bindings already says "push the bindings we saved away in maybe_save_op_lookup into the function parameter binding level", are you thinking of something else/more detailed? good enough, thanks -- Nathan Sidwell

Re: [C++ PATCH] PR c++/88123 - lambda and using-directive.

2019-03-08 Thread Jason Merrill
On Fri, Mar 8, 2019 at 8:04 AM Nathan Sidwell wrote: > > On 3/7/19 9:54 PM, Jason Merrill wrote: > > For named function calls in a template, the result of unqualified lookup is > > safed in CALL_EXPR_FN. But for operator expressions, no unqualified lookup > > is performed until we know whether th

Re: [C++ PATCH] PR c++/88123 - lambda and using-directive.

2019-03-08 Thread Nathan Sidwell
On 3/7/19 9:54 PM, Jason Merrill wrote: For named function calls in a template, the result of unqualified lookup is safed in CALL_EXPR_FN. But for operator expressions, no unqualified lookup is performed until we know whether the operands have class type. So when we see in a lambda a use of an

[C++ PATCH] PR c++/88123 - lambda and using-directive.

2019-03-07 Thread Jason Merrill
For named function calls in a template, the result of unqualified lookup is safed in CALL_EXPR_FN. But for operator expressions, no unqualified lookup is performed until we know whether the operands have class type. So when we see in a lambda a use of an operator that might be overloaded, we need