Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-12 Thread will wray
Thanks for the commit, for fixing the formatting issues and for writing the detailed ChangeLog entry. Sorry for those issues; all looks good now - there are only whitespace diffs between trunk and my patched version. My tests pass, including the test code attached to the bug report. Will IIRC I c

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-12 Thread Christophe Lyon
On Fri, 12 Oct 2018 at 07:47, Christophe Lyon wrote: > > On Fri, 12 Oct 2018 at 05:37, Jeff Law wrote: > > > > On 10/8/18 11:12 AM, will wray wrote: > > > Hi, > > > > > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > > > always falls back to C-style cast output > > > >

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-11 Thread Christophe Lyon
On Fri, 12 Oct 2018 at 05:37, Jeff Law wrote: > > On 10/8/18 11:12 AM, will wray wrote: > > Hi, > > > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > > always falls back to C-style cast output > > > > The fix is tested with the code attached to the bug report and additi

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-11 Thread Jeff Law
On 10/8/18 11:12 AM, will wray wrote: > Hi, > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > always falls back to C-style cast output > > The fix is tested with the code attached to the bug report and additional > usage over the past few weeks. > > Bootstrap and regt

Re: [C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-08 Thread Jason Merrill
OK. On Mon, Oct 8, 2018 at 1:12 PM will wray wrote: > > Hi, > > A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, > always falls back to C-style cast output > > The fix is tested with the code attached to the bug report and additional > usage over the past few weeks. > > Boot

[C++ PATCH] Fix pretty-print of enumerator ids (PR c++/87364)

2018-10-08 Thread will wray
Hi, A PR to fix Bug 87364 - Pretty print of enumerator never prints the id, always falls back to C-style cast output The fix is tested with the code attached to the bug report and additional usage over the past few weeks. Bootstrap and regtested on x86_64-linux. OK for trunk? 2018-10-08 Will