Re: [C++ PATCH] Fix decomp handling of unnamed bitfields (PR c++/84031)

2018-01-25 Thread Paolo Carlini
Hi, On 25/01/2018 17:25, Jason Merrill wrote: On Thu, Jan 25, 2018 at 11:17 AM, Paolo Carlini wrote: Hi all, On 25/01/2018 16:26, Jakub Jelinek wrote: + || (DECL_C_BIT_FIELD (field) && !DECL_NAME (field))) By the way, I see we are accumulating uses of DECL_C_BIT_FIELD && !DECL_NAME, s

Re: [C++ PATCH] Fix decomp handling of unnamed bitfields (PR c++/84031)

2018-01-25 Thread Jason Merrill
On Thu, Jan 25, 2018 at 11:17 AM, Paolo Carlini wrote: > Hi all, > > On 25/01/2018 16:26, Jakub Jelinek wrote: >> >> + || (DECL_C_BIT_FIELD (field) && !DECL_NAME (field))) > > By the way, I see we are accumulating uses of DECL_C_BIT_FIELD && > !DECL_NAME, shall we add a new macro? For Stage

Re: [C++ PATCH] Fix decomp handling of unnamed bitfields (PR c++/84031)

2018-01-25 Thread Paolo Carlini
Hi all, On 25/01/2018 16:26, Jakub Jelinek wrote: + || (DECL_C_BIT_FIELD (field) && !DECL_NAME (field))) By the way, I see we are accumulating uses of DECL_C_BIT_FIELD && !DECL_NAME, shall we add a new macro? For Stage 1? In case, how shall we name it? Paolo.

Re: [C++ PATCH] Fix decomp handling of unnamed bitfields (PR c++/84031)

2018-01-25 Thread Jason Merrill
OK. On Thu, Jan 25, 2018 at 10:26 AM, Jakub Jelinek wrote: > Hi! > > Unnamed bitfields are not data members, so we should ignore them when > counting the members or picking up members to initialize from, and > also should ignore them in find_decomp_class_base, they can appear > in various bases e

[C++ PATCH] Fix decomp handling of unnamed bitfields (PR c++/84031)

2018-01-25 Thread Jakub Jelinek
Hi! Unnamed bitfields are not data members, so we should ignore them when counting the members or picking up members to initialize from, and also should ignore them in find_decomp_class_base, they can appear in various bases etc. and still there could be just one base containing direct non-static