Re: [C++ PATCH] Fix clone_body (PR c++/86669)

2018-12-05 Thread Jakub Jelinek
On Wed, Dec 05, 2018 at 03:49:26PM -0500, Jason Merrill wrote: > On 11/28/18 3:42 AM, Jakub Jelinek wrote: > > Whenever we need to clone a cdtor (either because the target doesn't support > > aliases the way we need, e.g. initlist105.C testcase on darwin, where it has > > been originally reported,

Re: [C++ PATCH] Fix clone_body (PR c++/86669)

2018-12-05 Thread Jason Merrill
On 11/28/18 3:42 AM, Jakub Jelinek wrote: Whenever we need to clone a cdtor (either because the target doesn't support aliases the way we need, e.g. initlist105.C testcase on darwin, where it has been originally reported, or when it has virtual bases, like the made up initlist106.C on x86_64-linu

Patch ping (Re: [C++ PATCH] Fix clone_body (PR c++/86669))

2018-12-05 Thread Jakub Jelinek
Hi! On Wed, Nov 28, 2018 at 09:42:47AM +0100, Jakub Jelinek wrote: > 2018-11-28 Jakub Jelinek > > PR c++/86669 > * optimize.c (clone_body_copy_decl): New function. > (clone_body): Use it for base cdtors. Remap here only > DECL_INITIAL of decls that don't have DECL_CONT

Re: [C++ PATCH] Fix clone_body (PR c++/86669)

2018-11-28 Thread Jakub Jelinek
On Wed, Nov 28, 2018 at 09:42:47AM +0100, Jakub Jelinek wrote: > Bootstrapped/regtested on x86_64-linux and i686-linux (earlier version > without the insert_decl_map call), ok for trunk if it passes another > bootstrap/regtest in the current form? FYI, bootstrapped/regtested successfully on both.

[C++ PATCH] Fix clone_body (PR c++/86669)

2018-11-28 Thread Jakub Jelinek
Hi! Whenever we need to clone a cdtor (either because the target doesn't support aliases the way we need, e.g. initlist105.C testcase on darwin, where it has been originally reported, or when it has virtual bases, like the made up initlist106.C on x86_64-linux), we rely on DECL_INITIAL of the loca