Re: [C++ PATCH] Fix attribute parsing for bitfields

2017-09-28 Thread Nathan Sidwell
On 09/28/2017 11:47 AM, Jakub Jelinek wrote: I don't see the first half of 1) related to second half thereof, the DECL_BIT_FIELD_REPRESENTATIVE is unrelated to the parsing bug, and a needed precondition of 2). That's very conscientious of you. As I said on IRC, I hope [[/__attribute__/align

[C++ PATCH] Fix attribute parsing for bitfields

2017-09-28 Thread Jakub Jelinek
On Wed, Sep 27, 2017 at 07:55:20AM -0700, Nathan Sidwell wrote: > Jakub, > > The following patch implements P0386R1 - NSDMIs for bit-fields. > > While working on that, I've discovered our parser mishandles attributes > > on bitfields, already C++11 says: > > identifier[opt] attribute-specifier-seq[