Re: [C++ PATCH] Fix PR58705

2013-10-24 Thread Marek Polacek
On Thu, Oct 24, 2013 at 09:16:05AM -0400, Jason Merrill wrote: > On 10/14/2013 08:23 AM, Marek Polacek wrote: > >We were ICEing on the attached testcase, because in check_narrowing, > >for = {{}}, we wanted to check recursively the CONSTRUCTOR_ELTs, > >even though init in this case has 0 CONSTRUCTO

Re: [C++ PATCH] Fix PR58705

2013-10-24 Thread Jason Merrill
On 10/14/2013 08:23 AM, Marek Polacek wrote: We were ICEing on the attached testcase, because in check_narrowing, for = {{}}, we wanted to check recursively the CONSTRUCTOR_ELTs, even though init in this case has 0 CONSTRUCTOR_NELTS. So I added the check for CONSTRUCTOR_NELTS > 0. Moreover, sin

Re: [C++ PATCH] Fix PR58705

2013-10-21 Thread Marek Polacek
Ping. On Mon, Oct 14, 2013 at 02:23:59PM +0200, Marek Polacek wrote: > We were ICEing on the attached testcase, because in check_narrowing, > for = {{}}, we wanted to check recursively the CONSTRUCTOR_ELTs, > even though init in this case has 0 CONSTRUCTOR_NELTS. So I added > the check for CONSTR

[C++ PATCH] Fix PR58705

2013-10-14 Thread Marek Polacek
We were ICEing on the attached testcase, because in check_narrowing, for = {{}}, we wanted to check recursively the CONSTRUCTOR_ELTs, even though init in this case has 0 CONSTRUCTOR_NELTS. So I added the check for CONSTRUCTOR_NELTS > 0. Moreover, since empty scalar initializers are forbidden in C