Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-16 Thread H.J. Lu
On Mon, Dec 16, 2013 at 9:56 AM, Jakub Jelinek wrote: > On Mon, Dec 16, 2013 at 09:51:38AM -0800, H.J. Lu wrote: >> On Thu, Dec 12, 2013 at 5:36 AM, Jakub Jelinek wrote: >> > On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: >> >> It's only safe to free the targs if they weren't used

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-16 Thread Jakub Jelinek
On Mon, Dec 16, 2013 at 09:51:38AM -0800, H.J. Lu wrote: > On Thu, Dec 12, 2013 at 5:36 AM, Jakub Jelinek wrote: > > On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: > >> It's only safe to free the targs if they weren't used to instantiate > >> any templates, so I lean toward option

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-16 Thread H.J. Lu
On Thu, Dec 12, 2013 at 5:36 AM, Jakub Jelinek wrote: > On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: >> It's only safe to free the targs if they weren't used to instantiate >> any templates, so I lean toward option #1. Did you test this with >> strict gc? > > Ok, after IRC discu

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-13 Thread H.J. Lu
On Thu, Dec 12, 2013 at 5:36 AM, Jakub Jelinek wrote: > On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: >> It's only safe to free the targs if they weren't used to instantiate >> any templates, so I lean toward option #1. Did you test this with >> strict gc? > > Ok, after IRC discu

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-12 Thread Jakub Jelinek
On Wed, Dec 11, 2013 at 11:51:55AM -0500, Jason Merrill wrote: > It's only safe to free the targs if they weren't used to instantiate > any templates, so I lean toward option #1. Did you test this with > strict gc? Ok, after IRC discussion and another bootstrap/regtest I've installed this variant

Re: [C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-11 Thread Jason Merrill
It's only safe to free the targs if they weren't used to instantiate any templates, so I lean toward option #1. Did you test this with strict gc? Jason

[C++ PATCH] Fix GC related issues in C++ FE (PR c++/58627)

2013-12-11 Thread Jakub Jelinek
Hi! fn_type_unification does: /* We can't free this if a pending_template entry or * last_error_tinst_level is pointing at it. */