Re: [C++ PATCH] Fix -fno-weak ICE with inline vars (PR c++/89405)

2019-02-20 Thread Jason Merrill
On 2/20/19 12:25 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs with -fno-weak, because maybe_commonize_var clears TREE_PUBLIC/DECL_COMMON, but later we assume that if !DECL_INTERFACE_KNOWN that TREE_PUBLIC is true. Other spots that clear TREE_PUBLIC also set DECL_INTERFACE_KNOWN, e.g.

[C++ PATCH] Fix -fno-weak ICE with inline vars (PR c++/89405)

2019-02-20 Thread Jakub Jelinek
Hi! The following testcase ICEs with -fno-weak, because maybe_commonize_var clears TREE_PUBLIC/DECL_COMMON, but later we assume that if !DECL_INTERFACE_KNOWN that TREE_PUBLIC is true. Other spots that clear TREE_PUBLIC also set DECL_INTERFACE_KNOWN, e.g. twice in optimize.c: cp/optimize.c- TR