Re: [C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Marek Polacek
On Tue, Oct 06, 2015 at 11:46:33AM -0600, Jeff Law wrote: > >2015-10-06 Marek Polacek > > > > PR c++/67863 > > * call.c (build_conditional_expr_1): Build the COND_EXPR with > > a location. > > > > * c-c++-common/Wtautological-compare-4.c: New test. > OK. Committed. > Related,

Re: [C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Jeff Law
On 10/06/2015 11:29 AM, Marek Polacek wrote: I've been chasing a bogus -Wtautological-compare warning that only occurred in the C++ FE. Turned out that we were building COND_EXPRs without a location; that means that this code in warn_tautological_cmp didn't work as planned: /* Don't warn for

[C++ PATCH] Build COND_EXPRs with location (PR c++/67863)

2015-10-06 Thread Marek Polacek
I've been chasing a bogus -Wtautological-compare warning that only occurred in the C++ FE. Turned out that we were building COND_EXPRs without a location; that means that this code in warn_tautological_cmp didn't work as planned: /* Don't warn for various macro expansions. */ if (from_macro_