Re: [C++ PATCH] [PR86648] use auto identifier for class placeholder templates

2019-01-16 Thread Jason Merrill
On 1/16/19 11:10 PM, Alexandre Oliva wrote: On Jan 8, 2019, Jason Merrill wrote: On 12/28/18 2:45 PM, Alexandre Oliva wrote: + if (template_placeholder_p (t) + && DECL_P (CLASS_PLACEHOLDER_TEMPLATE (t)) + && TYPE_IDENTIFIER (TREE_TYPE (CLASS_PLACEHOLDER_TEMPLATE (t

Re: [C++ PATCH] [PR86648] use auto identifier for class placeholder templates

2019-01-16 Thread Alexandre Oliva
On Jan 8, 2019, Jason Merrill wrote: > On 12/28/18 2:45 PM, Alexandre Oliva wrote: >> + if (template_placeholder_p (t) >> + && DECL_P (CLASS_PLACEHOLDER_TEMPLATE (t)) >> + && TYPE_IDENTIFIER (TREE_TYPE (CLASS_PLACEHOLDER_TEMPLATE (t > Are these extra checks needed? Nope, tha

Re: [C++ PATCH] [PR86648] use auto identifier for class placeholder templates

2019-01-08 Thread Jason Merrill
On 12/28/18 2:45 PM, Alexandre Oliva wrote: dwarf2out recognizes unspecified auto types by the identifier. C++ template class placeholders are unspecified auto types that take the identifier of the class rather than those used by preexisting auto types, so dwarf2out ICEs when it finds one of th

[C++ PATCH] [PR86648] use auto identifier for class placeholder templates

2018-12-28 Thread Alexandre Oliva
dwarf2out recognizes unspecified auto types by the identifier. C++ template class placeholders are unspecified auto types that take the identifier of the class rather than those used by preexisting auto types, so dwarf2out ICEs when it finds one of those. Alas, they may be visible to dwarf2out,