Re: [C++] Add support for #pragma GCC unroll v4

2017-12-20 Thread Jason Merrill
On Wed, Dec 20, 2017 at 9:20 AM, Eric Botcazou wrote: >> This needs some C++ tests, particularly with templates and range-for. I >> suspect that using the pragma in a template will ICE. > > No, that wasn't the case, but the combination template/range-for was indeed > not working; fixed by adding

Re: [C++] Add support for #pragma GCC unroll v4

2017-12-20 Thread Eric Botcazou
> This needs some C++ tests, particularly with templates and range-for. I > suspect that using the pragma in a template will ICE. No, that wasn't the case, but the combination template/range-for was indeed not working; fixed by adding a 5th parameter to the RANGE_FOR_STMT node. Tested on x86_64

Re: [C++] Add support for #pragma GCC unroll v4

2017-12-13 Thread Jason Merrill
On 12/06/2017 03:50 AM, Eric Botcazou wrote: this is the (hopefully) final implementation of the support for the unrolling pragma in the C++ front-end. This needs some C++ tests, particularly with templates and range-for. I suspect that using the pragma in a template will ICE. Jason

Re: [C++] Add support for #pragma GCC unroll v4

2017-12-13 Thread Eric Botcazou
Ping for the last missing bits of the #pragma GCC unroll support: > this is the (hopefully) final implementation of the support for the > unrolling pragma in the C++ front-end. https://gcc.gnu.org/ml/gcc-patches/2017-12/msg00298.html Thanks in advance. -- Eric Botcazou

[C++] Add support for #pragma GCC unroll v4

2017-12-06 Thread Eric Botcazou
Hi, this is the (hopefully) final implementation of the support for the unrolling pragma in the C++ front-end. The only change is the handling of USHRT_MAX as unrolling factor which is now rejected (USHRT_MAX - 1 is the new upper bound). Tested on x86_64-suse-linux, OK for the mainline? 2017