Re: [Ada] Validity check failure with packed array and pragma

2017-09-19 Thread Pierre-Marie de Rodat
On 09/18/2017 10:09 PM, Eric Botcazou wrote: I'm not sure anyone really cares so it's up to you I'd say. Ok, thanks. Done! Committed as r252971. -- Pierre-Marie de Rodat

Re: [Ada] Validity check failure with packed array and pragma

2017-09-18 Thread Eric Botcazou
> That’s right, will do, thank you! Do I need to create a new ChangeLog > entry in gcc/testsuite/ or is it fine if I just keep the current “New > testcase.”? I'm not sure anyone really cares so it's up to you I'd say. -- Eric Botcazou

Re: [Ada] Validity check failure with packed array and pragma

2017-09-18 Thread Pierre-Marie de Rodat
On 09/18/2017 12:02 PM, Eric Botcazou wrote: You don't need this, just use: -- { dg-options "-O -gnatn -gnatVa -gnatws" } The -cargs/-margs trick is only needed for special switches like -dA. That’s right, will do, thank you! Do I need to create a new ChangeLog entry in gcc/testsuite/ or is

Re: [Ada] Validity check failure with packed array and pragma

2017-09-18 Thread Eric Botcazou
> 2017-09-18 Bob Duff > > * gnat.dg/validity_check.adb: New testcase. +-- { dg-options "-cargs -O -gnatn -gnatVa -gnatws -margs" } You don't need this, just use: -- { dg-options "-O -gnatn -gnatVa -gnatws" } The -cargs/-margs trick is only needed for special switches like -dA. --

[Ada] Validity check failure with packed array and pragma

2017-09-18 Thread Pierre-Marie de Rodat
Fix a bug in which if validity checking is enabled, Initialize_Scalars is enabled, optimization is turned on, and inlining is enabled, the initialization of a packed array can cause Constraint_Error to be incorrectly raised. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ 2017-09-18